Set User name and geo in native plugins
#1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
denrase
requested review from
marandaneto,
brustolin and
krystofwoldrich
as code owners
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1393 +/- ##
==========================================
- Coverage 89.91% 89.79% -0.12%
==========================================
Files 179 59 -120
Lines 5759 2018 -3741
==========================================
- Hits 5178 1812 -3366
+ Misses 581 206 -375 see 120 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 11fb408 | 320.10 ms | 380.24 ms | 60.14 ms |
| fdac48a | 329.50 ms | 396.46 ms | 66.96 ms |
| a7acb24 | 301.00 ms | 357.38 ms | 56.38 ms |
| eecbbca | 324.37 ms | 352.49 ms | 28.12 ms |
| 24f71aa | 358.49 ms | 455.90 ms | 97.41 ms |
| 2f8f173 | 323.31 ms | 373.29 ms | 49.97 ms |
| 6957bfd | 325.88 ms | 380.30 ms | 54.43 ms |
| 6325c3b | 339.33 ms | 409.86 ms | 70.53 ms |
| d7758e8 | 300.12 ms | 349.88 ms | 49.76 ms |
| 40680d3 | 323.55 ms | 390.29 ms | 66.73 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 11fb408 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
| fdac48a | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| a7acb24 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| eecbbca | 5.94 MiB | 6.89 MiB | 975.78 KiB |
| 24f71aa | 6.06 MiB | 7.03 MiB | 990.30 KiB |
| 2f8f173 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 6957bfd | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 6325c3b | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| d7758e8 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 40680d3 | 6.06 MiB | 7.03 MiB | 989.25 KiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 453e1bc | 1294.78 ms | 1308.10 ms | 13.33 ms |
| 633cf2e | 1257.96 ms | 1275.73 ms | 17.77 ms |
| 322aa66 | 1251.68 ms | 1275.52 ms | 23.84 ms |
| aa950e9 | 1275.17 ms | 1295.33 ms | 20.16 ms |
| a49594a | 1284.83 ms | 1313.29 ms | 28.45 ms |
| 3e5ee37 | 1248.25 ms | 1265.38 ms | 17.13 ms |
| 0be962b | 1264.10 ms | 1281.16 ms | 17.06 ms |
| 613760b | 1263.10 ms | 1277.27 ms | 14.16 ms |
| 134c9f8 | 1284.48 ms | 1306.18 ms | 21.70 ms |
| 9928a74 | 1249.98 ms | 1269.08 ms | 19.10 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 453e1bc | 8.16 MiB | 9.16 MiB | 1.00 MiB |
| 633cf2e | 8.15 MiB | 9.12 MiB | 986.26 KiB |
| 322aa66 | 8.15 MiB | 9.12 MiB | 992.53 KiB |
| aa950e9 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| a49594a | 8.16 MiB | 9.16 MiB | 1.00 MiB |
| 3e5ee37 | 8.15 MiB | 9.12 MiB | 986.23 KiB |
| 0be962b | 8.10 MiB | 9.16 MiB | 1.07 MiB |
| 613760b | 8.15 MiB | 9.13 MiB | 1000.46 KiB |
| 134c9f8 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
| 9928a74 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
|
@denrase there's a swift linting issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Set User name and geo in native plugins.
Closes #1065
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps
As soon as map from user/breadcrumb is merged on native side, this is also not needed anymore.