Add format action #1405
Merged
Add format action #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1405 +/- ##
==========================================
- Coverage 90.79% 88.64% -2.15%
==========================================
Files 61 141 +80
Lines 2042 4396 +2354
==========================================
+ Hits 1854 3897 +2043
- Misses 188 499 +311 ☔ View full report in Codecov by Sentry. |
denrase
requested review from
marandaneto,
brustolin and
krystofwoldrich
as code owners
marandaneto
reviewed
Apr 25, 2023
marandaneto
reviewed
Apr 25, 2023
marandaneto
reviewed
Apr 25, 2023
…art into feat/gh-format-action
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a609134 | 350.12 ms | 404.12 ms | 54.00 ms |
| 8e133ad | 360.08 ms | 402.82 ms | 42.74 ms |
| b2cbbc8 | 347.80 ms | 395.31 ms | 47.51 ms |
| aa950e9 | 337.42 ms | 400.72 ms | 63.30 ms |
| 5112c69 | 333.67 ms | 363.74 ms | 30.08 ms |
| 6325c3b | 339.33 ms | 409.86 ms | 70.53 ms |
| ef31c7f | 311.39 ms | 359.33 ms | 47.94 ms |
| 90db9ff | 334.86 ms | 388.14 ms | 53.28 ms |
| b98109e | 296.46 ms | 362.68 ms | 66.22 ms |
| 211a7aa | 324.19 ms | 393.26 ms | 69.07 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a609134 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 8e133ad | 6.06 MiB | 7.03 MiB | 990.29 KiB |
| b2cbbc8 | 6.06 MiB | 7.03 MiB | 995.45 KiB |
| aa950e9 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| 5112c69 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| 6325c3b | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| ef31c7f | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| 90db9ff | 6.06 MiB | 7.10 MiB | 1.04 MiB |
| b98109e | 6.06 MiB | 7.03 MiB | 993.53 KiB |
| 211a7aa | 6.06 MiB | 7.03 MiB | 997.24 KiB |
Previous results on branch: feat/gh-format-action
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 23d98b1 | 386.00 ms | 467.88 ms | 81.88 ms |
| 788426f | 305.06 ms | 369.12 ms | 64.06 ms |
| 3eaea3b | 395.38 ms | 464.82 ms | 69.43 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 23d98b1 | 6.06 MiB | 7.03 MiB | 995.56 KiB |
| 788426f | 6.06 MiB | 7.03 MiB | 997.23 KiB |
| 3eaea3b | 6.06 MiB | 7.03 MiB | 997.01 KiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 49a149b | 1296.47 ms | 1320.20 ms | 23.73 ms |
| 633cf2e | 1257.96 ms | 1275.73 ms | 17.77 ms |
| 5603ab2 | 1268.47 ms | 1280.73 ms | 12.26 ms |
| 8ced2dc | 1258.35 ms | 1272.98 ms | 14.62 ms |
| f2db4ec | 1244.14 ms | 1259.79 ms | 15.65 ms |
| 3e5ee37 | 1248.25 ms | 1265.38 ms | 17.13 ms |
| 333903e | 1251.15 ms | 1270.21 ms | 19.06 ms |
| 2331d89 | 1260.86 ms | 1281.24 ms | 20.39 ms |
| 134c9f8 | 1284.48 ms | 1306.18 ms | 21.70 ms |
| 379d7a8 | 1267.65 ms | 1288.39 ms | 20.74 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 49a149b | 8.15 MiB | 9.12 MiB | 986.26 KiB |
| 633cf2e | 8.15 MiB | 9.12 MiB | 986.26 KiB |
| 5603ab2 | 8.15 MiB | 9.12 MiB | 990.57 KiB |
| 8ced2dc | 8.10 MiB | 9.16 MiB | 1.07 MiB |
| f2db4ec | 8.10 MiB | 9.16 MiB | 1.07 MiB |
| 3e5ee37 | 8.15 MiB | 9.12 MiB | 986.23 KiB |
| 333903e | 8.10 MiB | 9.16 MiB | 1.06 MiB |
| 2331d89 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 134c9f8 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
| 379d7a8 | 8.16 MiB | 9.16 MiB | 1.00 MiB |
Previous results on branch: feat/gh-format-action
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 23d98b1 | 1265.63 ms | 1283.10 ms | 17.47 ms |
| 788426f | 1257.41 ms | 1291.71 ms | 34.31 ms |
| 3eaea3b | 1259.69 ms | 1266.96 ms | 7.27 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 23d98b1 | 8.10 MiB | 9.18 MiB | 1.08 MiB |
| 788426f | 8.10 MiB | 9.18 MiB | 1.08 MiB |
| 3eaea3b | 8.10 MiB | 9.18 MiB | 1.08 MiB |
|
@marandaneto Added the missing packages. We should probably still merge this with |
Yes, asked about this here. |
|
@denrase After finishing this, we could copy-reuse the very same implementation for https://github.com/getsentry/sentry-dart-plugin |
marandaneto
reviewed
May 8, 2023
marandaneto
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
dart format&dart fixand commits the changes, if there are any.💡 Motivation and Context
Closes #1357
Ran both format and fix in package
flutter&dartin this package. See commits.📝 Checklist
sendDefaultPiiis enabled