Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix battery level convertion for iOS 16.4 #1433

Merged
merged 3 commits into from May 10, 2023
Merged

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented May 10, 2023

📜 Description

Fix battery level convertion for iOS 16.4

💡 Motivation and Context

Closes #1432

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 312.04 ms 373.12 ms 61.08 ms
Size 6.06 MiB 7.03 MiB 997.04 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6957bfd 325.88 ms 380.30 ms 54.43 ms
fe4aa56 356.06 ms 428.67 ms 72.61 ms
ef2f368 350.06 ms 429.44 ms 79.38 ms
f96ca24 316.08 ms 388.22 ms 72.14 ms
6325c3b 339.33 ms 409.86 ms 70.53 ms
aed5947 295.70 ms 348.18 ms 52.48 ms
21845e2 345.08 ms 382.82 ms 37.74 ms
211a7aa 324.19 ms 393.26 ms 69.07 ms
11fb408 320.10 ms 380.24 ms 60.14 ms
519423f 357.00 ms 415.77 ms 58.77 ms

App size

Revision Plain With Sentry Diff
6957bfd 5.94 MiB 6.95 MiB 1.01 MiB
fe4aa56 6.06 MiB 7.10 MiB 1.04 MiB
ef2f368 5.94 MiB 6.89 MiB 975.81 KiB
f96ca24 6.06 MiB 7.10 MiB 1.04 MiB
6325c3b 5.94 MiB 6.96 MiB 1.02 MiB
aed5947 5.94 MiB 6.96 MiB 1.02 MiB
21845e2 5.94 MiB 6.92 MiB 1003.77 KiB
211a7aa 6.06 MiB 7.03 MiB 997.24 KiB
11fb408 6.06 MiB 7.10 MiB 1.04 MiB
519423f 6.06 MiB 7.03 MiB 989.24 KiB

Previous results on branch: chore/fix-ios-batterylevel

Startup times

Revision Plain With Sentry Diff
fdecca6 324.87 ms 393.24 ms 68.37 ms

App size

Revision Plain With Sentry Diff
fdecca6 6.06 MiB 7.03 MiB 997.04 KiB

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1288.92 ms 1300.00 ms 11.08 ms
Size 8.10 MiB 9.17 MiB 1.08 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2331d89 1260.86 ms 1281.24 ms 20.39 ms
f1314d5 1246.46 ms 1270.92 ms 24.46 ms
379d7a8 1267.65 ms 1288.39 ms 20.74 ms
f96ca24 1264.39 ms 1287.98 ms 23.59 ms
d301b11 1260.61 ms 1272.06 ms 11.45 ms
3a69405 1292.84 ms 1303.96 ms 11.12 ms
3334ac1 1259.22 ms 1275.40 ms 16.17 ms
ebfead1 1271.57 ms 1284.48 ms 12.91 ms
5aba417 1265.31 ms 1287.90 ms 22.59 ms
af2d175 1280.37 ms 1282.24 ms 1.88 ms

App size

Revision Plain With Sentry Diff
2331d89 8.16 MiB 9.17 MiB 1.01 MiB
f1314d5 8.10 MiB 9.08 MiB 1004.30 KiB
379d7a8 8.16 MiB 9.16 MiB 1.00 MiB
f96ca24 8.10 MiB 9.08 MiB 1004.36 KiB
d301b11 8.10 MiB 9.07 MiB 1000.82 KiB
3a69405 8.15 MiB 9.15 MiB 1018.56 KiB
3334ac1 8.10 MiB 9.17 MiB 1.08 MiB
ebfead1 8.10 MiB 9.16 MiB 1.07 MiB
5aba417 8.16 MiB 9.17 MiB 1.01 MiB
af2d175 8.15 MiB 9.12 MiB 986.22 KiB

Previous results on branch: chore/fix-ios-batterylevel

Startup times

Revision Plain With Sentry Diff
fdecca6 1286.51 ms 1301.49 ms 14.98 ms

App size

Revision Plain With Sentry Diff
fdecca6 8.10 MiB 9.17 MiB 1.08 MiB

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3a43905) 90.23% compared to head (f7af80c) 90.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1433   +/-   ##
=======================================
  Coverage   90.23%   90.24%           
=======================================
  Files         181      181           
  Lines        5788     5789    +1     
=======================================
+ Hits         5223     5224    +1     
  Misses        565      565           
Impacted Files Coverage Δ
dart/lib/src/protocol/sentry_device.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@marandaneto marandaneto merged commit bf4aed7 into main May 10, 2023
92 of 93 checks passed
@marandaneto marandaneto deleted the chore/fix-ios-batterylevel branch May 10, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_TypeError - Battery Level - iOS 16.4
3 participants