Deprecate extra in favor of contexts #1435

marandaneto · 2023-05-10T12:25:42Z

📜 Description

Deprecate extra in favor of contexts.

💡 Motivation and Context

https://docs.sentry.io/platforms/python/enriching-events/context/#additional-data

💚 How did you test it?

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
I updated the docs if needed
All tests passing
No breaking changes

🔮 Next steps

marandaneto · 2023-05-10T12:26:46Z

Change the target branch to main since I've created it from the wrong branch.

CHANGELOG.md

github-actions · 2023-05-10T15:29:21Z

Android Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	341.21 ms	400.47 ms	59.26 ms
Size	6.06 MiB	7.04 MiB	998.28 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e5b744f`	302.70 ms	342.17 ms	39.47 ms
`ecb4003`	332.58 ms	385.15 ms	52.57 ms
`e2d89fc`	323.84 ms	376.23 ms	52.39 ms
`895becc`	326.94 ms	376.02 ms	49.08 ms
`7ade5af`	341.04 ms	386.84 ms	45.80 ms
`0a23f98`	377.19 ms	416.18 ms	39.00 ms
`3a69405`	334.34 ms	369.19 ms	34.85 ms
`ad69abc`	297.35 ms	385.89 ms	88.54 ms
`9f9f94f`	331.04 ms	368.92 ms	37.88 ms
`deaeece`	347.42 ms	381.10 ms	33.68 ms

App size

Revision	Plain	With Sentry	Diff
`e5b744f`	6.06 MiB	7.09 MiB	1.03 MiB
`ecb4003`	6.06 MiB	7.09 MiB	1.03 MiB
`e2d89fc`	6.06 MiB	7.03 MiB	989.37 KiB
`895becc`	6.06 MiB	7.03 MiB	997.23 KiB
`7ade5af`	5.94 MiB	6.95 MiB	1.01 MiB
`0a23f98`	6.06 MiB	7.03 MiB	996.97 KiB
`3a69405`	5.94 MiB	6.95 MiB	1.01 MiB
`ad69abc`	6.06 MiB	7.09 MiB	1.03 MiB
`9f9f94f`	5.94 MiB	6.95 MiB	1.01 MiB
`deaeece`	5.94 MiB	6.96 MiB	1.02 MiB

Previous results on branch: chore/deprecate-extra

Startup times

Revision	Plain	With Sentry	Diff
`35c4a29`	318.53 ms	382.90 ms	64.36 ms
`7ef5a88`	299.46 ms	364.27 ms	64.81 ms

App size

Revision	Plain	With Sentry	Diff
`35c4a29`	6.06 MiB	7.03 MiB	997.05 KiB
`7ef5a88`	6.06 MiB	7.03 MiB	997.02 KiB

krystofwoldrich

Looks good. The PR is still a draft will you be adding something more?

marandaneto · 2023-05-11T08:58:38Z

Looks good. The PR is still a draft will you be adding something more?

I was just waiting CI/linting, but probably not.

codecov · 2023-05-11T09:02:16Z

Codecov Report

Patch and project coverage have no change.

Comparison is base (801068d) 90.20% compared to head (0b6d15b) 90.20%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1435   +/-   ##
=======================================
  Coverage   90.20%   90.20%           
=======================================
  Files         181      181           
  Lines        5789     5789           
=======================================
  Hits         5222     5222           
  Misses        567      567

Impacted Files	Coverage Δ
dart/lib/src/protocol/sentry_event.dart	`100.00% <ø> (ø)`
dart/lib/src/protocol/sentry_transaction.dart	`90.90% <ø> (ø)`
dart/lib/src/scope.dart	`98.35% <ø> (ø)`
...nt_processor/flutter_enricher_event_processor.dart	`94.18% <ø> (ø)`
...ib/src/integrations/load_contexts_integration.dart	`99.02% <ø> (ø)`
...ter/lib/src/view_hierarchy/sentry_tree_walker.dart	`100.00% <ø> (ø)`
logging/lib/src/extension.dart	`100.00% <ø> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

github-actions · 2023-05-11T09:27:57Z

iOS Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1245.25 ms	1258.76 ms	13.51 ms
Size	8.10 MiB	9.17 MiB	1.08 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`6957bfd`	1283.80 ms	1289.00 ms	5.20 ms
`c1bb00f`	1265.14 ms	1290.85 ms	25.71 ms
`a49594a`	1284.83 ms	1313.29 ms	28.45 ms
`211a7aa`	1258.02 ms	1275.65 ms	17.63 ms
`457a85b`	1275.17 ms	1285.51 ms	10.34 ms
`aed5947`	1268.67 ms	1281.10 ms	12.43 ms
`8e133ad`	1268.19 ms	1277.37 ms	9.18 ms
`873fb42`	1261.00 ms	1285.92 ms	24.92 ms
`90db9ff`	1277.18 ms	1283.69 ms	6.51 ms
`2f8f173`	1280.61 ms	1292.20 ms	11.59 ms

App size

Revision	Plain	With Sentry	Diff
`6957bfd`	8.15 MiB	9.15 MiB	1020.71 KiB
`c1bb00f`	8.09 MiB	9.07 MiB	1001.06 KiB
`a49594a`	8.16 MiB	9.16 MiB	1.00 MiB
`211a7aa`	8.10 MiB	9.18 MiB	1.08 MiB
`457a85b`	8.09 MiB	9.07 MiB	1000.88 KiB
`aed5947`	8.16 MiB	9.17 MiB	1.01 MiB
`8e133ad`	8.10 MiB	9.16 MiB	1.07 MiB
`873fb42`	8.16 MiB	9.17 MiB	1.01 MiB
`90db9ff`	8.10 MiB	9.08 MiB	1004.27 KiB
`2f8f173`	8.15 MiB	9.13 MiB	1000.39 KiB

Previous results on branch: chore/deprecate-extra

Startup times

Revision	Plain	With Sentry	Diff
`35c4a29`	1254.32 ms	1287.57 ms	33.25 ms

App size

Revision	Plain	With Sentry	Diff
`35c4a29`	8.10 MiB	9.17 MiB	1.08 MiB

…art into chore/deprecate-extra

diegog-sf · 2023-05-24T18:51:03Z

logging/lib/src/extension.dart

@@ -28,6 +28,7 @@ extension LogRecordX on LogRecord {
      level: level.toSentryLevel(),
      message: SentryMessage(message),
      throwable: error,
+      // ignore: deprecated_member_use


Hello, I would like to see PR that migrates the current variables in extra so that I can replicate the same steps on our app that has a custom implementation of sentry_logging

is is ok to attach specific error data to the suggested context?

yes, it's preferred actually https://docs.sentry.io/platforms/python/enriching-events/context/#additional-data
Although extra still works, and its probably not going to be removed any time soon, it's a soft deprecation as of now.

marandaneto added 2 commits May 10, 2023 09:39

Fix battery level convertion for iOS 16.4

fdecca6

Deprecate extra in favor of contexts

35c4a29

marandaneto changed the base branch from main to chore/fix-ios-batterylevel May 10, 2023 12:26

marandaneto changed the title ~~Fix battery level convertion for iOS 16.4~~ Deprecate extra in favor of contexts May 10, 2023

Base automatically changed from chore/fix-ios-batterylevel to main May 10, 2023 15:10

marandaneto added 2 commits May 10, 2023 17:11

Merge branch 'main' of github.com:getsentry/sentry-dart

137caae

Merge branch 'main' into chore/deprecate-extra

5ac8f4c

marandaneto commented May 10, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

a596998

marandaneto closed this May 10, 2023

marandaneto reopened this May 10, 2023

krystofwoldrich approved these changes May 11, 2023

View reviewed changes

marandaneto marked this pull request as ready for review May 11, 2023 08:58

marandaneto requested a review from stefanosiano as a code owner May 11, 2023 08:58

marandaneto closed this May 11, 2023

marandaneto reopened this May 11, 2023

getsentry-bot added 2 commits May 11, 2023 08:59

Format & fix code

49aeb83

Format & fix code

6ca299e

marandaneto and others added 3 commits May 11, 2023 11:09

fix

7ef5a88

Format & fix code

f695994

Format & fix code

267b7af

marandaneto closed this May 11, 2023

marandaneto reopened this May 11, 2023

marandaneto added 2 commits May 15, 2023 10:22

fix conflicts

d26e288

fix

67e8452

marandaneto and others added 2 commits May 15, 2023 10:33

fix changelog

5bb368e

Format & fix code

6df51d6

marandaneto closed this May 15, 2023

marandaneto reopened this May 15, 2023

marandaneto added 3 commits May 15, 2023 10:43

fix

4f4fbaa

Merge branch 'chore/deprecate-extra' of github.com:getsentry/sentry-d…

500bfd0

…art into chore/deprecate-extra

fix

0b6d15b

marandaneto enabled auto-merge (squash) May 15, 2023 09:01

marandaneto merged commit 62de927 into main May 15, 2023
94 of 96 checks passed

marandaneto deleted the chore/deprecate-extra branch May 15, 2023 09:13

diegog-sf reviewed May 24, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate extra in favor of contexts #1435

Deprecate extra in favor of contexts #1435

marandaneto commented May 10, 2023 •

edited

marandaneto commented May 10, 2023

github-actions bot commented May 10, 2023 •

edited

Baseline results on branch: main

Startup times

App size

Previous results on branch: chore/deprecate-extra

Startup times

App size

krystofwoldrich left a comment

marandaneto commented May 11, 2023

codecov bot commented May 11, 2023 •

edited

github-actions bot commented May 11, 2023

Baseline results on branch: main

Startup times

App size

Previous results on branch: chore/deprecate-extra

Startup times

App size

diegog-sf May 24, 2023

marandaneto May 25, 2023

Deprecate extra in favor of contexts #1435

Deprecate extra in favor of contexts #1435

Conversation

marandaneto commented May 10, 2023 • edited

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

marandaneto commented May 10, 2023

github-actions bot commented May 10, 2023 • edited

Android Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: chore/deprecate-extra

Startup times

App size

krystofwoldrich left a comment

Choose a reason for hiding this comment

marandaneto commented May 11, 2023

codecov bot commented May 11, 2023 • edited

Codecov Report

github-actions bot commented May 11, 2023

iOS Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: chore/deprecate-extra

Startup times

App size

diegog-sf May 24, 2023

Choose a reason for hiding this comment

marandaneto May 25, 2023

Choose a reason for hiding this comment

marandaneto commented May 10, 2023 •

edited

github-actions bot commented May 10, 2023 •

edited

codecov bot commented May 11, 2023 •

edited