-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support package_info_plus 4.x #1436
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1436 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 61 61
Lines 2042 2042
=======================================
Hits 1854 1854
Misses 188 188 ☔ View full report in Codecov by Sentry. |
@ThexXTURBOXx thanks, can you add a changelog entry? https://github.com/getsentry/sentry-dart/blob/main/CHANGELOG.md |
@ThexXTURBOXx also this:
Let's do the |
I thought about this for a bit and it might be more advisable to add a breaking change instead and increment the Please let me know what you think. |
Based on what I see, the class already checks SDK version for compatibility. This is just to ensure that the SDK compiles, you can still force minAPi 19 in your final app, we compile our sample with the min. supported version as well
The AGP plugin checks if there's any class being used that is not supported < 16 and will fail the build, if that happens, then maybe increasing the version is the way to go. |
Sorry, I of course meant |
Since this is still not working I will close this in favor of #1440 |
📜 Description
This PR adds support for
package_info_plus 4.x
💡 Motivation and Context
It fixes compatibility problems when using AGP 8.x by supporting a "fixed" version of package_info_plus.
There might be other libraries which do not support that yet, but they can probably be separately updated later.
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps