Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip setup linux #1450

Merged
merged 3 commits into from
May 15, 2023
Merged

Skip setup linux #1450

merged 3 commits into from
May 15, 2023

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented May 15, 2023

📜 Description

#skip-changelog

💡 Motivation and Context

E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/universe/n/ninja-build/ninja-build_1.10.1-1_amd64.deb Unable to connect to azure.archive.ubuntu.com:http: [IP: 40.119.46.219 80]

The latest images don't require this extra setup anyway.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.74 🎉

Comparison is base (04abed0) 88.78% compared to head (2acebcb) 90.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1450      +/-   ##
==========================================
+ Coverage   88.78%   90.53%   +1.74%     
==========================================
  Files         126      175      +49     
  Lines        3950     5503    +1553     
==========================================
+ Hits         3507     4982    +1475     
- Misses        443      521      +78     

see 49 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto marandaneto marked this pull request as ready for review May 15, 2023 12:12
@marandaneto marandaneto changed the title Skip setup linux if possible Skip setup linux May 15, 2023
@marandaneto marandaneto merged commit 1c42829 into main May 15, 2023
90 of 92 checks passed
@marandaneto marandaneto deleted the chore/skip-setup-linux branch May 15, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants