Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting latest Dart #1463

Merged
merged 2 commits into from
May 22, 2023
Merged

Fix formatting latest Dart #1463

merged 2 commits into from
May 22, 2023

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented May 19, 2023

📜 Description

#skip-changelog

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c73ab67) 90.20% compared to head (0d701dd) 90.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1463   +/-   ##
=======================================
  Coverage   90.20%   90.20%           
=======================================
  Files         181      181           
  Lines        5788     5788           
=======================================
  Hits         5221     5221           
  Misses        567      567           
Impacted Files Coverage Δ
dart/lib/src/protocol/sentry_event.dart 100.00% <ø> (ø)
dart/lib/src/protocol/sentry_request.dart 98.18% <ø> (ø)
dart/lib/src/protocol/sentry_transaction.dart 90.90% <ø> (ø)
dart/lib/src/protocol/sentry_user.dart 92.68% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 328.96 ms 385.61 ms 56.65 ms
Size 6.15 MiB 7.13 MiB 999.96 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c1bb00f 303.77 ms 371.88 ms 68.11 ms
8a7f528 290.27 ms 341.80 ms 51.53 ms
f4cc744 349.53 ms 394.68 ms 45.15 ms
457a85b 312.37 ms 376.67 ms 64.31 ms
6d317ea 303.46 ms 356.06 ms 52.60 ms
2331d89 352.45 ms 417.34 ms 64.89 ms
333903e 332.76 ms 406.86 ms 74.10 ms
b47809a 333.42 ms 368.36 ms 34.95 ms
521cfbf 332.78 ms 376.04 ms 43.26 ms
21845e2 345.08 ms 382.82 ms 37.74 ms

App size

Revision Plain With Sentry Diff
c1bb00f 6.06 MiB 7.09 MiB 1.03 MiB
8a7f528 6.06 MiB 7.03 MiB 989.36 KiB
f4cc744 5.94 MiB 6.95 MiB 1.01 MiB
457a85b 6.06 MiB 7.09 MiB 1.03 MiB
6d317ea 5.94 MiB 6.92 MiB 1001.74 KiB
2331d89 5.94 MiB 6.96 MiB 1.02 MiB
333903e 6.06 MiB 7.10 MiB 1.04 MiB
b47809a 5.94 MiB 6.96 MiB 1.02 MiB
521cfbf 5.94 MiB 6.97 MiB 1.03 MiB
21845e2 5.94 MiB 6.92 MiB 1003.77 KiB

Previous results on branch: chore/fix-formatting

Startup times

Revision Plain With Sentry Diff
7953594 313.06 ms 376.82 ms 63.76 ms

App size

Revision Plain With Sentry Diff
7953594 6.15 MiB 7.11 MiB 982.35 KiB

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2023

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.02 ms 1233.29 ms 5.27 ms
Size 8.29 MiB 9.36 MiB 1.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
69670c9 1269.18 ms 1288.69 ms 19.51 ms
7f2b01d 1253.92 ms 1266.70 ms 12.78 ms
895becc 1288.00 ms 1308.63 ms 20.63 ms
af2d175 1280.37 ms 1282.24 ms 1.88 ms
521cfbf 1258.94 ms 1275.18 ms 16.25 ms
ebfead1 1271.57 ms 1284.48 ms 12.91 ms
d301b11 1260.61 ms 1272.06 ms 11.45 ms
21845e2 1279.37 ms 1298.81 ms 19.45 ms
ef2f368 1259.12 ms 1277.04 ms 17.92 ms
a1a1545 1270.85 ms 1289.82 ms 18.96 ms

App size

Revision Plain With Sentry Diff
69670c9 8.10 MiB 9.08 MiB 1004.49 KiB
7f2b01d 8.16 MiB 9.16 MiB 1.00 MiB
895becc 8.10 MiB 9.18 MiB 1.08 MiB
af2d175 8.15 MiB 9.12 MiB 986.22 KiB
521cfbf 8.16 MiB 9.17 MiB 1.01 MiB
ebfead1 8.10 MiB 9.16 MiB 1.07 MiB
d301b11 8.10 MiB 9.07 MiB 1000.82 KiB
21845e2 8.15 MiB 9.12 MiB 991.34 KiB
ef2f368 8.15 MiB 9.10 MiB 965.24 KiB
a1a1545 8.16 MiB 9.17 MiB 1.01 MiB

Previous results on branch: chore/fix-formatting

Startup times

Revision Plain With Sentry Diff
7953594 1230.00 ms 1257.90 ms 27.90 ms

App size

Revision Plain With Sentry Diff
7953594 8.29 MiB 9.36 MiB 1.07 MiB

@marandaneto marandaneto mentioned this pull request May 19, 2023
6 tasks
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@marandaneto marandaneto merged commit 6572f8d into main May 22, 2023
94 of 96 checks passed
@marandaneto marandaneto deleted the chore/fix-formatting branch May 22, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants