New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use recordHttpBreadcrumbs
to set iOS enableNetworkBreadcrumbs
#1884
Conversation
|
Android Performance metrics 馃殌
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
117d988 | 376.32 ms | 450.85 ms | 74.53 ms |
48e79fd | 354.22 ms | 391.46 ms | 37.24 ms |
3f3ef0b | 382.24 ms | 459.26 ms | 77.02 ms |
1a93825 | 347.31 ms | 424.54 ms | 77.23 ms |
6a40d32 | 292.09 ms | 350.81 ms | 58.73 ms |
891efac | 378.00 ms | 461.20 ms | 83.20 ms |
bd37365 | 360.79 ms | 440.74 ms | 79.95 ms |
732a7b4 | 371.98 ms | 423.19 ms | 51.21 ms |
9d7e862 | 426.35 ms | 510.88 ms | 84.53 ms |
754cdbe | 325.08 ms | 390.53 ms | 65.45 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
117d988 | 6.33 MiB | 7.26 MiB | 947.03 KiB |
48e79fd | 5.94 MiB | 6.95 MiB | 1.01 MiB |
3f3ef0b | 6.33 MiB | 7.26 MiB | 943.11 KiB |
1a93825 | 6.27 MiB | 7.20 MiB | 956.36 KiB |
6a40d32 | 6.16 MiB | 7.14 MiB | 1003.99 KiB |
891efac | 6.27 MiB | 7.20 MiB | 958.73 KiB |
bd37365 | 6.27 MiB | 7.20 MiB | 957.75 KiB |
732a7b4 | 6.33 MiB | 7.27 MiB | 954.02 KiB |
9d7e862 | 6.33 MiB | 7.26 MiB | 943.41 KiB |
754cdbe | 6.16 MiB | 7.14 MiB | 1003.78 KiB |
iOS Performance metrics 馃殌
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0118295 | 1211.31 ms | 1227.02 ms | 15.71 ms |
fe4aa56 | 1248.82 ms | 1261.35 ms | 12.53 ms |
ccc09e4 | 1254.74 ms | 1277.08 ms | 22.34 ms |
d883d62 | 1221.39 ms | 1230.18 ms | 8.80 ms |
62de927 | 1242.46 ms | 1246.11 ms | 3.65 ms |
86d4841 | 1225.69 ms | 1241.12 ms | 15.43 ms |
26e955b | 1232.35 ms | 1258.88 ms | 26.52 ms |
62dde43 | 1258.43 ms | 1276.81 ms | 18.38 ms |
08a7b4f | 1277.10 ms | 1303.37 ms | 26.27 ms |
379d7a8 | 1267.65 ms | 1288.39 ms | 20.74 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
0118295 | 8.32 MiB | 9.38 MiB | 1.05 MiB |
fe4aa56 | 8.10 MiB | 9.08 MiB | 1004.36 KiB |
ccc09e4 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
d883d62 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
62de927 | 8.29 MiB | 9.37 MiB | 1.08 MiB |
86d4841 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
26e955b | 8.28 MiB | 9.34 MiB | 1.05 MiB |
62dde43 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
08a7b4f | 8.16 MiB | 9.16 MiB | 1.01 MiB |
379d7a8 | 8.16 MiB | 9.16 MiB | 1.00 MiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃憤
@buenaflor Do you know why some screenshot tests are failing? |
@denrase seems like something is up with the flutter beta channel with |
@buenaflor After debugging this (for a while -.-), I found that using |
馃摐 Description
We could not disable http breadcrumbs when running on iOS. This PR uses the
recordHttpBreadcrumbs
option to setenableNetworkBreadcrumbs
option on the iOS side. This is the same mechanism as thecaptureFailedRequests
toenableCaptureFailedRequests
option pair.馃挕 Motivation and Context
Closes #1873
馃挌 How did you test it?
Unit tests
馃摑 Checklist
sendDefaultPii
is enabled