-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrates to package:web and js_interop #2104
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompatible with package:web 0.5.1
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v9 #2104 +/- ##
==========================================
- Coverage 95.25% 88.63% -6.62%
==========================================
Files 54 220 +166
Lines 1791 7623 +5832
==========================================
+ Hits 1706 6757 +5051
- Misses 85 866 +781 ☔ View full report in Codecov by Sentry. |
6 tasks
We can close this now as we don't plan to bump the versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Continuation of #2064 by josh-burton
Additions:
Updated & Re-run
ffigen
to generate bindings with updated parameters.💡 Motivation and Context
Supports compilation via WASM
💚 How did you test it?
Make sure CI runs without issues.
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps
This is a rather large bump for us, and we will probably create a pre-release version if we choose to go with this approach.
Still to resolve