Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates to package:web and js_interop #2104

Closed
wants to merge 29 commits into from
Closed

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jun 17, 2024

📜 Description

Continuation of #2064 by josh-burton

Additions:

  • Bump sentry packages to Dart 3.3.0 and Flutter 3.19.0

Updated & Re-run ffigen to generate bindings with updated parameters.

💡 Motivation and Context

Supports compilation via WASM

💚 How did you test it?

Make sure CI runs without issues.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

This is a rather large bump for us, and we will probably create a pre-release version if we choose to go with this approach.

Still to resolve

  • We use [packae_info_plus], which added support for wasm in Version 6.0.0., which also requirise dart 3.3.0

@denrase denrase changed the title Package web Migrates to package:web and js_interop Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.63%. Comparing base (3cac5bf) to head (7bb2685).

Files Patch % Lines
...tter/lib/src/native/cocoa/sentry_native_cocoa.dart 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v9    #2104      +/-   ##
==========================================
- Coverage   95.25%   88.63%   -6.62%     
==========================================
  Files          54      220     +166     
  Lines        1791     7623    +5832     
==========================================
+ Hits         1706     6757    +5051     
- Misses         85      866     +781     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denrase denrase changed the base branch from main to v9 June 17, 2024 12:24
@buenaflor
Copy link
Contributor

We can close this now as we don't plan to bump the versions

@buenaflor buenaflor closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants