-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Client Report Envelope Item #810
Feat: Client Report Envelope Item #810
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the code, it looks good to me.
I'm not fully aware of the specifics on "client report".
@marandaneto can take a look at that.
Codecov Report
@@ Coverage Diff @@
## feat/client-report-recorder #810 +/- ##
===============================================================
+ Coverage 89.70% 89.94% +0.23%
===============================================================
Files 118 9 -109
Lines 3700 169 -3531
===============================================================
- Hits 3319 152 -3167
+ Misses 381 17 -364 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a high-level concept point of view. Can't add some feedback to the dart code. Thanks for doing this 👏
Conceptually seems fine. Though I see some build check failures? |
A few files were renamed but not on test files, likely a merging issue @denrase ? |
@marandaneto Sry about that, let me check/fix |
#skip-changelog
📜 Description
Create envelope item from client report model.
💡 Motivation and Context
The item will be added to an envelope so we can send it to the backend.
💚 How did you test it?
Unit tests.
📝 Checklist