Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Reports: Record Network Errors #830

Merged
merged 4 commits into from
Apr 19, 2022

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Apr 13, 2022

#skip-changelog

馃摐 Description

Record all network errors >=400 except 429.

馃挕 Motivation and Context

Completes client report recording.

馃挌 How did you test it?

  • Unit tests

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@denrase denrase mentioned this pull request Apr 13, 2022
13 tasks
@denrase denrase marked this pull request as ready for review April 13, 2022 08:38
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022

Codecov Report

Merging #830 (2e8f35b) into feat/client-reports (2518bca) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@                   Coverage Diff                   @@
##           feat/client-reports     #830      +/-   ##
=======================================================
+ Coverage                90.16%   90.22%   +0.05%     
=======================================================
  Files                      119      119              
  Lines                     3742     3744       +2     
=======================================================
+ Hits                      3374     3378       +4     
+ Misses                     368      366       -2     
Impacted Files Coverage 螖
dart/lib/src/transport/http_transport.dart 94.11% <100.00%> (+0.17%) 猬嗭笍
...rc/client_reports/noop_client_report_recorder.dart 100.00% <0.00%> (+66.66%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2518bca...2e8f35b. Read the comment docs.

@marandaneto
Copy link
Contributor

@denrase there is an issue with testing:

test/sentry_browser_test.dart: SentryEvent user overrides client [E]
NoSuchMethodError: method not found: '$index' on null

@denrase denrase merged commit fdb6ba6 into feat/client-reports Apr 19, 2022
@denrase denrase deleted the feat/client-reports-http-errors branch April 19, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants