Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs for slack threads options #10117

Merged
merged 3 commits into from
May 28, 2024
Merged

add docs for slack threads options #10117

merged 3 commits into from
May 28, 2024

Conversation

ykamo001
Copy link
Contributor

@ykamo001 ykamo001 commented May 22, 2024

DESCRIBE YOUR PR

We added the ability to toggle threads on or off at the integration level for all users! Adding documentation so that users know how to change the toggle, and we can use the link to help support users who ask.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 5:42pm

@ykamo001 ykamo001 requested review from vivianyentran and a team May 22, 2024 23:34
Copy link

codecov bot commented May 22, 2024

Bundle Report

Changes will increase total bundle size by 549 bytes ⬆️

Bundle name Size Change
sentry-docs-server 7.43MB 552 bytes ⬆️
sentry-docs-edge-server 461.86kB 3 bytes ⬇️
sentry-docs-client 6.19MB 0 bytes

Copy link
Member

@AbhiPrasad AbhiPrasad May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be named docs/organization/integrations/notification-incidents/threads/img/slack-threads-features.png

theards -> threads

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
Co-authored-by: Cathy Teng <70817427+cathteng@users.noreply.github.com>
@ykamo001 ykamo001 merged commit 275fc8c into master May 28, 2024
6 checks passed
@ykamo001 ykamo001 deleted the threads branch May 28, 2024 18:01
matejminar pushed a commit that referenced this pull request Jun 6, 2024
* add docs for slack threads options

* rename

* Apply suggestions from code review

Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
Co-authored-by: Cathy Teng <70817427+cathteng@users.noreply.github.com>

---------

Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
Co-authored-by: Cathy Teng <70817427+cathteng@users.noreply.github.com>
a-hariti pushed a commit that referenced this pull request Jun 8, 2024
* add docs for slack threads options

* rename

* Apply suggestions from code review

Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
Co-authored-by: Cathy Teng <70817427+cathteng@users.noreply.github.com>

---------

Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
Co-authored-by: Cathy Teng <70817427+cathteng@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants