Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented request tracing requirement for an active transaction on the scope to the .NET docs #10118

Merged
merged 3 commits into from
May 27, 2024

Conversation

jamescrosswell
Copy link
Contributor

DESCRIBE YOUR PR

Added docs explaining that transactions/spans don't get created for outbound HTTP requests when there is an active transaction on the scope, when using the .NET SDK.

Resolves getsentry/sentry-dotnet#3370

IS YOUR CHANGE URGENT?

  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
    CC: @bitsandfoxes for review

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented May 23, 2024

@jamescrosswell is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

…atic-instrumentation.mdx

Co-authored-by: Stefan Jandl <reg@bitfox.at>
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small suggestion.

…atic-instrumentation.mdx

Co-authored-by: Liza Mock <lizka920@gmail.com>
Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 9:19am

@bitsandfoxes bitsandfoxes merged commit 4521403 into getsentry:master May 27, 2024
5 checks passed
lforst pushed a commit that referenced this pull request May 28, 2024
matejminar pushed a commit that referenced this pull request Jun 6, 2024
a-hariti pushed a commit that referenced this pull request Jun 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document requirement for active scope transaction
3 participants