-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documented request tracing requirement for an active transaction on the scope to the .NET docs #10118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jamescrosswell is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
docs/platforms/dotnet/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
…atic-instrumentation.mdx Co-authored-by: Stefan Jandl <reg@bitfox.at>
lizokm
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one small suggestion.
docs/platforms/dotnet/common/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
…atic-instrumentation.mdx Co-authored-by: Liza Mock <lizka920@gmail.com>
bitsandfoxes
approved these changes
May 27, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lforst
pushed a commit
that referenced
this pull request
May 28, 2024
…he scope to the .NET docs (#10118) Awesome!
matejminar
pushed a commit
that referenced
this pull request
Jun 6, 2024
…he scope to the .NET docs (#10118) Awesome!
a-hariti
pushed a commit
that referenced
this pull request
Jun 8, 2024
…he scope to the .NET docs (#10118) Awesome!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Added docs explaining that transactions/spans don't get created for outbound HTTP requests when there is an active transaction on the scope, when using the .NET SDK.
Resolves getsentry/sentry-dotnet#3370
IS YOUR CHANGE URGENT?
SLA
CC: @bitsandfoxes for review
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: