Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Metrics Setup docs for the dotnet SDK to prepare for GA #10119

Closed

Conversation

jamescrosswell
Copy link
Contributor

DESCRIBE YOUR PR

Resolves getsentry/sentry-dotnet#3245

When Metrics are GA, the syntax for enabling Metrics in the .NET SDK will change.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Other deadline: Whenever Metrics are GA

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.

@bitsandfoxes I'm having difficulty with this one. I can't work out how to change what shows in the "ON THIS PAGE" pane... this doesn't appear to update automatically when I add new H1, H2 headers etc.

Once we're happy with the content, I imagine we'll also want to update:
docs/platforms/unity/metrics/index.mdx

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented May 23, 2024

@jamescrosswell is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 6:23pm

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions!

docs/platforms/dotnet/common/metrics/index.mdx Outdated Show resolved Hide resolved
@@ -14,6 +12,8 @@ Metrics for .NET are supported with Sentry .NET SDK version `4.0.0` and above.

Sentry metrics help you pinpoint and solve issues that impact user experience and app performance by measuring the data points that are important to you. You can track things like processing time, event size, user signups, and conversion rates, then correlate them back to tracing data in order to get deeper insights and solve issues faster.

# Custom metrics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Custom metrics
# Custom Metrics
Sentry comes with built-in metrics, such as performance metrics and web vitals. You can also send custom metrics to Sentry to track the data points you care about most. This page describes how to set up and send custom metrics to use with our [Metrics feature](/product/metrics/).

Wasn't sure if you meant to add more here as it's still a draft, but I think including an intro paragraph here to contextualize the rest of the info for this page would help.

docs/platforms/dotnet/common/metrics/index.mdx Outdated Show resolved Hide resolved
docs/platforms/dotnet/common/metrics/index.mdx Outdated Show resolved Hide resolved
docs/platforms/dotnet/common/metrics/index.mdx Outdated Show resolved Hide resolved
docs/platforms/dotnet/common/metrics/index.mdx Outdated Show resolved Hide resolved
docs/platforms/dotnet/common/metrics/index.mdx Outdated Show resolved Hide resolved
docs/platforms/dotnet/common/metrics/index.mdx Outdated Show resolved Hide resolved
jamescrosswell and others added 8 commits May 24, 2024 09:48
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
@getsantry
Copy link
Contributor

getsantry bot commented Jun 19, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jun 19, 2024
@jamescrosswell
Copy link
Contributor Author

Metrics are apparently going live soon

@getsantry getsantry bot closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare Metrics for GA
2 participants