Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Better documentation for unhandled rejections warnings #1099

Merged
merged 2 commits into from Jul 15, 2019
Merged

docs: Better documentation for unhandled rejections warnings #1099

merged 2 commits into from Jul 15, 2019

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek requested a review from HazAT July 3, 2019 16:38
@kamilogorek kamilogorek mentioned this pull request Jul 3, 2019
Closed
8 tasks
@kamilogorek kamilogorek requested review from MimiDumpling and removed request for HazAT July 12, 2019 09:06
MimiDumpling
MimiDumpling reviewed Jul 12, 2019
View reviewed changes
Copy link
Contributor

@MimiDumpling MimiDumpling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few grammar and language changes.

src/collections/_documentation/platforms/node/default-integrations.md Outdated Show resolved Hide resolved
src/collections/_documentation/platforms/node/index.md Outdated Show resolved Hide resolved
@kamilogorek @MimiDumpling
Apply suggestions from code review
30e5511 
Co-Authored-By: Tien "Mimi" Nguyen <tienmiminguyen@gmail.com>
@kamilogorek kamilogorek merged commit 5aa5a6d into master Jul 15, 2019
@kamilogorek kamilogorek deleted the rejections-flag branch July 15, 2019 08:38
@MimiDumpling
Copy link
Contributor

👍

@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HazAT HazAT HazAT approved these changes

@MimiDumpling MimiDumpling Awaiting requested review from MimiDumpling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node suggestion: log errors in unhandledRejection
3 participants
@kamilogorek @MimiDumpling @HazAT