Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Xamarin Wizard #2809

Merged
merged 11 commits into from
Jan 27, 2021
Merged

Conversation

lucas-zimerman
Copy link
Contributor

@lucas-zimerman lucas-zimerman commented Dec 27, 2020

The following pull request adds to the doc a Wizard for Xamarin Forms.

@vercel
Copy link

vercel bot commented Dec 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/qgrkw0eqn/sentry.dev
✅ Preview: https://sentry-docs-git-fork-lucas-zimerman-feat-xamarin.sentry.dev

src/wizard/dotnet/xamarin.md Outdated Show resolved Hide resolved
src/wizard/dotnet/xamarin.md Outdated Show resolved Hide resolved
src/wizard/dotnet/xamarin.md Outdated Show resolved Hide resolved
src/wizard/dotnet/xamarin.md Outdated Show resolved Hide resolved
src/wizard/dotnet/xamarin.md Outdated Show resolved Hide resolved
src/wizard/dotnet/xamarin.md Outdated Show resolved Hide resolved
src/wizard/dotnet/xamarin.md Outdated Show resolved Hide resolved
src/wizard/dotnet/xamarin.md Outdated Show resolved Hide resolved
src/wizard/dotnet/xamarin.md Outdated Show resolved Hide resolved
src/wizard/dotnet/xamarin.md Outdated Show resolved Hide resolved
src/wizard/dotnet/xamarin.md Show resolved Hide resolved
@lucas-zimerman lucas-zimerman changed the title feat: Xamarin Wizzard feat: Xamarin Wizard Dec 29, 2020
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 1 nit left

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed tabs in favor of spaces. Added ___PUBLIC_DSN___ note the 3 _ which gets replaced by Sentry with your DSN

src/wizard/dotnet/xamarin.md Outdated Show resolved Hide resolved
src/wizard/dotnet/xamarin.md Outdated Show resolved Hide resolved
src/wizard/dotnet/xamarin.md Outdated Show resolved Hide resolved
Comment on lines 60 to 64
SentryXamarin.Init(options =>
{
options.Dsn = "__YOUR__DSN__";
});
...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SentryXamarin.Init(options =>
{
options.Dsn = "__YOUR__DSN__";
});
...
SentryXamarin.Init(options =>
{
options.Dsn = "___PUBLIC_DSN___";
});

Update Wizard with Sentry.Xamarin + Sentry.Xamarin.Forms.
src/wizard/dotnet/xamarin.md Outdated Show resolved Hide resolved
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants