Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Xamarin docs #2909

Merged
merged 10 commits into from
Jan 27, 2021
Merged

Conversation

lucas-zimerman
Copy link
Contributor

The following pull request adds to sentry-docs the Xamarin and Xamarin forms doc page.

@vercel
Copy link

vercel bot commented Jan 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/poloqrko3/sentry.dev
✅ Preview: https://sentry-docs-git-fork-lucas-zimerman-feat-xamarin-docs.sentry.dev

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need a few more changes though:

https://sentry-docs-git-fork-lucas-zimerman-feat-xamarin-docs.sentry.dev/platforms/dotnet/guides/xamarin/ignoring-exceptions/

This snippet would need to be rewritten:
This file: https://github.com/getsentry/sentry-docs/blob/master/src/platforms/dotnet/common/ignoring-exceptions.mdx

Could be copied to dotnet/guides/xamarin/common/ignoring-exceptions.mdx and changed to SentryXamarin.Init.

src/platforms/dotnet/guides/xamarin/config.yml Outdated Show resolved Hide resolved
src/platforms/dotnet/guides/xamarin/index.mdx Outdated Show resolved Hide resolved
src/platforms/dotnet/guides/xamarin/index.mdx Outdated Show resolved Hide resolved
requested changes.

Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
@vercel
Copy link

vercel bot commented Jan 21, 2021

@lucas-zimerman is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

src/includes/set-release/xamarin.mdx Outdated Show resolved Hide resolved
@@ -0,0 +1,10 @@
```csharp {tabTitle:C#}
using Sentry;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this Sentry.Xamarin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are using namespace Sentry for the public classes.

@bruno-garcia bruno-garcia merged commit 40f4a7b into getsentry:master Jan 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants