Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update RN troubleshooting docs for promise polyfill fix #4525

Merged
merged 6 commits into from
Jan 10, 2022

Conversation

jennmueng
Copy link
Member

Documents auto promise patching added in getsentry/sentry-react-native#1984 and demonstrates how to disable the patching or how to use the patching with other polyfilling libraries.

@jennmueng jennmueng requested a review from a team as a code owner December 21, 2021 23:21
@vercel
Copy link

vercel bot commented Dec 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/ANmErd7syQb427WNHYXZf7a9NWnj
✅ Preview: https://sentry-docs-git-fork-jennmueng-jenn-promise-polyfill.sentry.dev

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We can merge this after the holidays when we merge the PR in the RN repo and make a release there


#### Disable Auto Patching

You can disable the global promise patching by passing `patchGlobalPromise: false` either in `Sentry.init` or the `ReactNativeErrorHandlers` integration. Note that if you disable our auto patching, to ensure that unhandled rejections are still caught you will need to [manually force a package resolution](#manually-forcing-a-package-resolution);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding this option to the Configuration page too.

Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor wording changes

src/platforms/react-native/troubleshooting.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/troubleshooting.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/troubleshooting.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/troubleshooting.mdx Outdated Show resolved Hide resolved
src/platforms/react-native/troubleshooting.mdx Outdated Show resolved Hide resolved
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
marandaneto and others added 4 commits January 10, 2022 20:27
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
@marandaneto marandaneto merged commit d258749 into getsentry:master Jan 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants