feat(perf): Add Performance Metrics Docs for JavaScript #5285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Adds documentation around automatic and custom performance metrics.
AbhiPrasad
force-pushed
the
performance-metrics-docs
branch
from
46fb783
to
d4b0d53
Compare
imatwawana
reviewed
Jul 13, 2022
src/platforms/common/performance/instrumentation/performance-metrics.mdx
Outdated
Show resolved
Hide resolved
src/includes/performance/automatic-performance-metrics/javascript.mdx
Outdated
Show resolved
Hide resolved
src/includes/performance/automatic-performance-metrics/javascript.mdx
Outdated
Show resolved
Hide resolved
src/includes/performance/automatic-performance-metrics/javascript.mdx
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,14 @@ | |||
| Supported in Sentry's JavaScript SDK version `7.0.0` and above. | |||
There was a problem hiding this comment.
I can't make this change without the back ticks for the code snippet interfering with the back ticks of the suggestion, but I would put the sentence above (on line 1) in a note after that code snippet.
There was a problem hiding this comment.
Ugh, I wish they would fix that. Just for convenience, can we do that in a separate PR?
src/platforms/common/performance/instrumentation/performance-metrics.mdx
Outdated
Show resolved
Hide resolved
src/platforms/common/performance/instrumentation/performance-metrics.mdx
Outdated
Show resolved
Hide resolved
src/platforms/common/performance/instrumentation/performance-metrics.mdx
Outdated
Show resolved
Hide resolved
src/platforms/common/performance/instrumentation/performance-metrics.mdx
Outdated
Show resolved
Hide resolved
src/platforms/common/performance/instrumentation/performance-metrics.mdx
Show resolved
Hide resolved
7 tasks
src/includes/performance/automatic-performance-metrics/javascript.mdx
Outdated
Show resolved
Hide resolved
src/platforms/common/performance/instrumentation/performance-metrics.mdx
Outdated
Show resolved
Hide resolved
src/platforms/common/performance/instrumentation/performance-metrics.mdx
Outdated
Show resolved
Hide resolved
src/platforms/common/performance/instrumentation/performance-metrics.mdx
Show resolved
Hide resolved
src/platforms/common/performance/instrumentation/performance-metrics.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
src/platforms/common/performance/instrumentation/performance-metrics.mdx
Outdated
Show resolved
Hide resolved
src/platforms/common/performance/instrumentation/performance-metrics.mdx
Outdated
Show resolved
Hide resolved
src/platforms/common/performance/instrumentation/performance-metrics.mdx
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,14 @@ | |||
| Supported in Sentry's JavaScript SDK version `7.0.0` and above. | |||
There was a problem hiding this comment.
Ugh, I wish they would fix that. Just for convenience, can we do that in a separate PR?
src/platforms/common/performance/instrumentation/performance-metrics.mdx
Outdated
Show resolved
Hide resolved
src/platforms/common/performance/instrumentation/performance-metrics.mdx
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #5257
Adds documentation around automatic and custom performance metrics for JavaScript.
I think this is an initial base we can keep building off of. Eventually we'll need to link to https://sentry-docs-glcb7uyhn.sentry.dev/product/sentry-basics/events-metrics/#custom-performance-measurements.