-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capacitor: Add troubleshooting for Sibling SDKs #5656
Capacitor: Add troubleshooting for Sibling SDKs #5656
Conversation
@lucas-zimerman is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
Why there are so many error messages here? https://github.com/getsentry/sentry-docs/actions/runs/3273680513/jobs/5386204335#step:6:20 |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I'm pretty sure that's the system seeing all the code snippets but that they're formatted in a way that it can't execute them and freaking out. It's expected behaviour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some wording edits and recommended some structural changes. I also left a question. Please ping me for review when you've had a chance to make changes.
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a couple wording edits and left a question.
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I made one last wording suggestion, but this is good to go!
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Is this ready to merge? |
I can't merge it but yes, it is :D |
* Add troubleshooting for sibling sdks * Remove spaces * Extra line * Apply suggestions from code review Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> * move error message to the top and extra line added * Update src/platforms/javascript/guides/capacitor/troubleshooting.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> * Update src/platforms/javascript/guides/capacitor/troubleshooting.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com> Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
The PR explains the importance of using the exact version of the Sibling SDK for Capacitor and a side effect of not doing so.
Wizard was also updated in order to avoid mismatched versions when installing Sentry Capacitor with a sibling SDK.