Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capacitor: Add troubleshooting for Sibling SDKs #5656

Merged

Conversation

lucas-zimerman
Copy link
Contributor

The PR explains the importance of using the exact version of the Sibling SDK for Capacitor and a side effect of not doing so.

Wizard was also updated in order to avoid mismatched versions when installing Sentry Capacitor with a sibling SDK.

@vercel
Copy link

vercel bot commented Oct 17, 2022

@lucas-zimerman is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@lucas-zimerman
Copy link
Contributor Author

lucas-zimerman commented Oct 18, 2022

@vercel
Copy link

vercel bot commented Oct 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Nov 17, 2022 at 3:26PM (UTC)

@imatwawana
Copy link
Contributor

Why there are so many error messages here? https://github.com/getsentry/sentry-docs/actions/runs/3273680513/jobs/5386204335#step:6:20

I'm pretty sure that's the system seeing all the code snippets but that they're formatted in a way that it can't execute them and freaking out. It's expected behaviour.

Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some wording edits and recommended some structural changes. I also left a question. Please ping me for review when you've had a chance to make changes.

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a couple wording edits and left a question.

src/wizard/capacitor/index.md Outdated Show resolved Hide resolved
lucas-zimerman and others added 2 commits October 26, 2022 18:23
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I made one last wording suggestion, but this is good to go!

@imatwawana imatwawana removed the request for review from lizokm November 10, 2022 14:12
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
@imatwawana
Copy link
Contributor

Is this ready to merge?

@lucas-zimerman
Copy link
Contributor Author

Is this ready to merge?

I can't merge it but yes, it is :D

@imatwawana imatwawana merged commit 9f41bdd into getsentry:master Nov 18, 2022
lforst pushed a commit that referenced this pull request Nov 22, 2022
* Add troubleshooting for sibling sdks

* Remove spaces

* Extra line

* Apply suggestions from code review

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

* move error message to the top and extra line added

* Update src/platforms/javascript/guides/capacitor/troubleshooting.mdx

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

* Update src/platforms/javascript/guides/capacitor/troubleshooting.mdx

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants