Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP Client errors docs for iOS #5702

Merged
merged 10 commits into from
Nov 4, 2022
Merged

HTTP Client errors docs for iOS #5702

merged 10 commits into from
Nov 4, 2022

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 31, 2022 •
edited

@vercel
Copy link

vercel bot commented Oct 31, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Nov 4, 2022 at 6:53AM (UTC)

@marandaneto marandaneto mentioned this pull request Oct 31, 2022
Merged
5 tasks
imatwawana
imatwawana reviewed Oct 31, 2022
View reviewed changes
Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some wording tweaks

src/platforms/apple/common/configuration/http-client-errors.mdx Outdated Show resolved Hide resolved
src/platforms/apple/common/configuration/http-client-errors.mdx Outdated Show resolved Hide resolved
src/platforms/apple/common/configuration/http-client-errors.mdx Outdated Show resolved Hide resolved
src/platforms/apple/common/configuration/http-client-errors.mdx Outdated Show resolved Hide resolved
src/platforms/apple/common/configuration/http-client-errors.mdx Outdated Show resolved Hide resolved
src/platforms/apple/common/configuration/http-client-errors.mdx Outdated Show resolved Hide resolved
src/platforms/common/configuration/options.mdx Outdated Show resolved Hide resolved
marandaneto and others added 7 commits October 31, 2022 15:45
@marandaneto @imatwawana
Update src/platforms/apple/common/configuration/http-client-errors.mdx
e167cf4 
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
@marandaneto @imatwawana
Update src/platforms/apple/common/configuration/http-client-errors.mdx
6216eab 
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
@marandaneto @imatwawana
Update src/platforms/common/configuration/options.mdx
fc09441 
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
@marandaneto @imatwawana
Update src/platforms/apple/common/configuration/http-client-errors.mdx
2172794 
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
@marandaneto @imatwawana
Update src/platforms/apple/common/configuration/http-client-errors.mdx
3d0ae3a 
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
@marandaneto @imatwawana
Update src/platforms/apple/common/configuration/http-client-errors.mdx
696a93b 
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
@marandaneto @imatwawana
Update src/platforms/apple/common/configuration/http-client-errors.mdx
2913cf8 
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
@marandaneto
Copy link
Contributor Author

@philipphofmann @brustolin review here would be nice, thanks.

@marandaneto marandaneto mentioned this pull request Nov 3, 2022
Closed
@marandaneto marandaneto marked this pull request as ready for review November 3, 2022 14:41
@marandaneto marandaneto requested a review from a team as a code owner November 3, 2022 14:41
@marandaneto marandaneto closed this Nov 3, 2022
@marandaneto marandaneto reopened this Nov 3, 2022
philipphofmann
philipphofmann reviewed Nov 3, 2022
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the feature to the following locations:

sentry-docs/src/platform-includes/getting-started-config/apple.mdx

Lines 15 to 18 in 431dee6

// Features turned off by default, but worth checking out
options.enableAppHangTracking = true
options.enableFileIOTracking = true
options.enableCoreDataTracking = true

sentry-docs/src/platform-includes/getting-started-config/apple.mdx

Lines 34 to 37 in 431dee6

// Features turned off by default, but worth checking out
options.enableAppHangTracking = YES;
options.enableFileIOTracking = YES;
options.enableCoreDataTracking = YES;

sentry-docs/src/platform-includes/getting-started-config/apple.mdx

Lines 56 to 59 in 431dee6

// Features turned off by default, but worth checking out
options.enableAppHangTracking = true
options.enableFileIOTracking = true
options.enableCoreDataTracking = true

And also the wizard please

sentry-docs/src/wizard/apple/ios.md

Lines 41 to 44 in 431dee6

// Features turned off by default, but worth checking out
options.enableAppHangTracking = true
options.enableFileIOTracking = true
options.enableCoreDataTracking = true

sentry-docs/src/wizard/apple/ios.md

Lines 67 to 70 in 431dee6

// Features turned off by default, but worth checking out
options.enableAppHangTracking = true
options.enableFileIOTracking = true
options.enableCoreDataTracking = true

src/platforms/apple/common/configuration/http-client-errors.mdx Outdated Show resolved Hide resolved
src/platforms/apple/common/configuration/swizzling.mdx
@@ -12,6 +12,7 @@ __macOS__
- <PlatformLink to="/performance/instrumentation/automatic-instrumentation/#file-io-tracking">Auto instrumentation for File I/O operations</PlatformLink>
- <PlatformLink to="/performance/instrumentation/automatic-instrumentation/#core-data-tracking">Auto instrumentation for Core Data operations</PlatformLink>
- <PlatformLink to="/performance/connect-services/">Automatically added sentry-trace header to HTTP requests for distributed tracing</PlatformLink>
- <PlatformLink to="/configuration/http-client-errors/">HTTP Client Errors</PlatformLink>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 for adding it here.

@philipphofmann
Copy link
Member

🥇 Thank you @marandaneto for also creating the docs for this feature.

@marandaneto marandaneto enabled auto-merge (squash) November 4, 2022 06:39
@marandaneto marandaneto merged commit 3fad325 into master Nov 4, 2022
@marandaneto marandaneto deleted the chore/http-client-errors-ios branch November 4, 2022 06:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@philipphofmann philipphofmann philipphofmann left review comments

@imatwawana imatwawana imatwawana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marandaneto @philipphofmann @imatwawana