Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for beforeSendTransaction in Java #6037

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Jan 9, 2023

Docs for filtering transactions via beforeSendTransaction

getsentry/sentry-java#2358

@vercel
Copy link

vercel bot commented Jan 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 30, 2023 at 0:02AM (UTC)

@romtsn
Copy link
Member

romtsn commented Jan 9, 2023

Hm, shouldn't this go under https://sentry-docs-git-feat-before-send-transaction-java.sentry.dev/platforms/android/configuration/filtering/#using-sampling-to-filter-transaction-events perhaps? Maybe we could rename it to Filter Transaction Events or something like that.

Because now it's under Filter Error Events section, which feels kinda wrong.. @lizokm maybe you could help us here with the structure?

@romtsn romtsn requested a review from lizokm January 9, 2023 10:51
@adinauer
Copy link
Member Author

adinauer commented Jan 9, 2023

@romtsn just discussed with team. There's some PR(s) going on around restructuring. It's fine to add where others placed it for now as it'll be moved anyways.

@lizokm
Copy link
Contributor

lizokm commented Jan 10, 2023

I'll also take a look at this today @romtsn, @adinauer.

@adinauer
Copy link
Member Author

@lizokm do you still plan on giving this a review or can I go ahead and merge?

@adinauer
Copy link
Member Author

Merging now, if there's any feedback, just let me know, I can send another PR to improve.

@adinauer adinauer merged commit ae0a98e into master Jan 31, 2023
@adinauer adinauer deleted the feat/before-send-transaction-java branch January 31, 2023 08:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants