Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(astro): Document assets sourcemaps upload option #8586

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 27, 2023

This small PR adds documentation for the new assets option soon to be released in the Astro
SDK. Functionality it's 1:1 on par with the Vite plugin assets option but we don't expose the
full Vite Plugin API in the Astro SDK; hence the dedicated documentation.

Only merge after getsentry/sentry-javascript#9668 is relased but otherwise ready to review

Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 10:24am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs-next ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2023 10:24am

@Lms24 Lms24 changed the title feat(astro): Document assets sourcemaps upload option feat(astro): Document assets sourcemaps upload option Nov 27, 2023
@Lms24 Lms24 marked this pull request as ready for review November 27, 2023 17:06
@Lms24 Lms24 requested a review from lforst November 27, 2023 17:06
Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Just a couple of small suggestions.

Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
@Lms24 Lms24 enabled auto-merge (squash) November 29, 2023 10:19
@Lms24 Lms24 merged commit a34e6c5 into master Nov 29, 2023
9 checks passed
@Lms24 Lms24 deleted the lms/feat-astro-assets-option branch November 29, 2023 10:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants