feat: Format code blocks at build time #9373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lforst
reviewed
Mar 7, 2024
|
PHP plugin seems to choke on the top level I will wait on this for now until we have a clear idea of the preferred code formatting conventions among PHP developers |
a-hariti
changed the title
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
lforst
approved these changes
Apr 2, 2024
Bundle ReportChanges will increase total bundle size by 1.55kB ⬆️
|
|
Can we push this through @lforst? |
lforst
changed the title
antonpirker
pushed a commit
that referenced
this pull request
May 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-merge checklist
If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.
Description of changes
Format code blocks at build time in a transpilation fashion using Prettier
Ignores code blocks with
diffmetadata to avoid confusion due to leading+and-charactersRight now supports languages that are supported of the box by Prettier, there's room for more support for other languages through plugins
resolves #9057