-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replay): Replay canvas troubleshooting docs #9559
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will decrease total bundle size by 21 bytes ⬇️
|
@@ -17,6 +17,10 @@ This guide aims to extend the <PlatformLink to="/troubleshooting/">main troubles | |||
|
|||
Canvas is supported in SDK versions >= `7.98.0`. Please see the <PlatformLink to="/session-replay/#canvas-recording">canvas setup documention</PlatformLink> to get started with canvas recordings. | |||
|
|||
## My `canvas` has been tainted | |||
|
|||
Set `crossorigin="anonymous"` on your images. This will allow images that are loaded from foreign origins to be used in `canvas` as if they have been loaded from the current origin. See the [CORS documention](https://developer.mozilla.org/en-US/docs/Web/HTML/CORS_enabled_image) for more information about this error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe link directly to the Security and tainted canvases
header https://developer.mozilla.org/en-US/docs/Web/HTML/CORS_enabled_image#security_and_tainted_canvases
@@ -17,6 +17,10 @@ This guide aims to extend the <PlatformLink to="/troubleshooting/">main troubles | |||
|
|||
Canvas is supported in SDK versions >= `7.98.0`. Please see the <PlatformLink to="/session-replay/#canvas-recording">canvas setup documention</PlatformLink> to get started with canvas recordings. | |||
|
|||
## My `canvas` has been tainted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think users will know what "tainted" means in this context - I think we should move this paragraph into the above section because it will look like canvas is not being captured.
We should say something like, If you are on a supported SDK version and your canvas elements still aren't being captured, check if you have images or videos inside of your canvas that are loaded from foreign origins. You may also see a SecurityError
being thrown when trying to use the replay canvas integration. ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but would like a @vivianyentran to double check the new words
docs/platforms/javascript/common/session-replay/troubleshooting.mdx
Outdated
Show resolved
Hide resolved
…g.mdx Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
Adds troubleshooting section for canvas being tainted
![image](https://private-user-images.githubusercontent.com/55311782/317057227-e5c3dd9f-d2df-48e5-9e7f-f37a7fbb831c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAzMjQ3NzcsIm5iZiI6MTcyMDMyNDQ3NywicGF0aCI6Ii81NTMxMTc4Mi8zMTcwNTcyMjctZTVjM2RkOWYtZDJkZi00OGU1LTllN2YtZjM3YTdmYmI4MzFjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA3VDAzNTQzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBjYjZmYTY0ODg0ZTY4NmVmOWFjYmYxMGU1NWU5MzYzOGE3NTA2MTk2ZTlhNmZlOWNmMmQxYjE3Njc3NTRiNGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.9e7rb2cGiA1Nu9JuTPqdax2xTwYkwQ9LJxkdPRDK6gY)
Fixes #9515