feat(apple): Filter app hang events #9822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explain how to filter app hang events in beforeSend.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will decrease total bundle size by 12 bytes ⬇️
|
kahest
approved these changes
Apr 26, 2024
| SentrySDK.start { options in | ||
| options.dsn = "___PUBLIC_DSN___" | ||
| options.beforeSend = { event in | ||
| if (event.exceptions?.first?.type == "App Hanging") { |
There was a problem hiding this comment.
l: is this preferred to checking mechanism , e.g if event.exceptions?.contains(where: { $0.mechanism?.type = "AppHang" }) {?
There was a problem hiding this comment.
Right now yes. We could also consider making isAppHangEvent of the Event.m public https://github.com/getsentry/sentry-cocoa/blob/aa45f3606be62823e6f0fd8f0d6a704b16867e17/Sources/Sentry/SentryEvent.m#L203-L207.
vivianyentran
approved these changes
Apr 26, 2024
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-merge checklist
If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.
Description of changes
Explain how to filter app hang events in beforeSend.