Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cmd+k/esc keyboard interaction on Search #9977

Merged
merged 2 commits into from
May 9, 2024
Merged

feat: Cmd+k/esc keyboard interaction on Search #9977

merged 2 commits into from
May 9, 2024

Conversation

a-hariti
Copy link
Collaborator

@a-hariti a-hariti commented May 9, 2024

It's the law!!

image

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 3:21pm

Copy link

codecov bot commented May 9, 2024

Bundle Report

Changes will increase total bundle size by 2.06kB ⬆️

Bundle name Size Change
sentry-docs-server 7.43MB 589 bytes ⬆️
sentry-docs-edge-server 456.68kB 3 bytes ⬇️
sentry-docs-client 6.16MB 1.48kB ⬆️

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks for adding!

@lizokm lizokm merged commit 89cf497 into master May 9, 2024
8 checks passed
@lizokm lizokm deleted the cmdk branch May 9, 2024 15:32
antonpirker pushed a commit that referenced this pull request May 14, 2024
* feat: Cmd+k/esc search keyboard interaction

* add hokey hint to Search filed
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants