Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

fix: Remove stacktrace from event #38

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Jun 3, 2019

Stacktrace belongs to a Thread or an Exception.

Resolves #18

@codecov-io
Copy link

codecov-io commented Jun 3, 2019

Codecov Report

Merging #38 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #38      +/-   ##
=========================================
- Coverage   94.93%   94.9%   -0.04%     
=========================================
  Files          25      25              
  Lines         652     471     -181     
=========================================
- Hits          619     447     -172     
+ Misses         33      24       -9
Impacted Files Coverage Δ
src/Sentry.Protocol/SentryEvent.cs 100% <ø> (ø) ⬆️
src/Sentry.Protocol/Context/Contexts.cs 89.28% <0%> (-10.72%) ⬇️
src/Sentry.Protocol/CollectionsExtensions.cs 90% <0%> (-10%) ⬇️
src/Sentry.Protocol/Dsn.cs 94.11% <0%> (-5.89%) ⬇️
src/Sentry.Protocol/User.cs 95.65% <0%> (-4.35%) ⬇️
src/Sentry.Protocol/Request.cs 96.66% <0%> (-3.34%) ⬇️
src/Sentry.Protocol/BaseScopeExtensions.cs 83.33% <0%> (+3.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d1d2bf...5b05d8a. Read the comment docs.

@bruno-garcia bruno-garcia merged commit 3c1bd17 into master Jun 3, 2019
@bruno-garcia bruno-garcia deleted the fix/remove-root-stacktrace branch June 3, 2019 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move stacktrace to threads
2 participants