Apply suggestions from code review

getsentry · Jul 13, 2021 · 3415b47 · 3415b47
1 parent c7ed62b
commit 3415b47
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,7 +6,7 @@
 
 - ASP.NET Core: fix handled not being set for Handled exceptions ([#1111](https://github.com/getsentry/sentry-dotnet/pull/1111))
 
-### Changed
+### Features
 
 - File system persistence for sessions ([#1105](https://github.com/getsentry/sentry-dotnet/pull/1105))
 

diff --git a/src/Sentry/GlobalSessionManager.cs b/src/Sentry/GlobalSessionManager.cs
@@ -237,9 +237,9 @@ private void DeletePersistedSession()
                 return;
             }
 
+            var filePath = Path.Combine(_persistenceDirectoryPath, PersistedSessionFileName);
             try
             {
-                var filePath = Path.Combine(_persistenceDirectoryPath, PersistedSessionFileName);
 
                 // Try to log the contents of the session file before we delete it
                 if (_options.DiagnosticLogger?.IsEnabled(SentryLevel.Debug) ?? false)
@@ -271,8 +271,9 @@ private void DeletePersistedSession()
             catch (Exception ex)
             {
                 _options.DiagnosticLogger?.LogError(
-                    "Failed to delete persisted session from the file system.",
-                    ex
+                    "Failed to delete persisted session from the file system: '{0}'",
+                    ex,
+                    filePath
                 );
             }
         }