Made most of the SpanContext constructor parameters optional

getsentry · Oct 11, 2023 · b723ca0 · b723ca0
1 parent 9873fb0
commit b723ca0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/src/Sentry.OpenTelemetry/SentrySpanProcessor.cs b/src/Sentry.OpenTelemetry/SentrySpanProcessor.cs
@@ -66,10 +66,10 @@ public override void OnStart(Activity data)
         {
             // We can find the parent span - start a child span.
             var context = new SpanContext(
+                data.OperationName,
                 data.SpanId.AsSentrySpanId(),
                 data.ParentSpanId.AsSentrySpanId(),
                 data.TraceId.AsSentryId(),
-                data.OperationName,
                 data.DisplayName,
                 null,
                 null)

diff --git a/src/Sentry/SpanContext.cs b/src/Sentry/SpanContext.cs
@@ -37,13 +37,13 @@ public class SpanContext : ITraceContext
     /// Initializes an instance of <see cref="SpanContext"/>.
     /// </summary>
     public SpanContext(
-        SpanId? spanId,
-        SpanId? parentSpanId,
-        SentryId? traceId,
         string operation,
-        string? description,
-        SpanStatus? status,
-        bool? isSampled)
+        SpanId? spanId = null,
+        SpanId? parentSpanId = null,
+        SentryId? traceId = null,
+        string? description = null,
+        SpanStatus? status = null,
+        bool? isSampled = null)
     {
         SpanId = spanId ?? SpanId.Create();
         ParentSpanId = parentSpanId;

diff --git a/src/Sentry/TransactionContext.cs b/src/Sentry/TransactionContext.cs
@@ -31,7 +31,7 @@ public class TransactionContext : SpanContext, ITransactionContext
         bool? isParentSampled = null,
         TransactionNameSource nameSource = TransactionNameSource.Custom
     )
-        : base(spanId, parentSpanId, traceId, operation, description, status, isSampled)
+        : base(operation, spanId, parentSpanId, traceId, description, status, isSampled)
     {
         Name = name;
         IsParentSampled = isParentSampled;