Sentry debug logging crashes because of argument confusion in LogError() methods

[Zero3]

Please mark the type framework used:

• ASP.NET MVC
• ASP.NET Web API (OWIN)
• ASP.NET Core
• WPF
• WinForms
• Xamarin
• Other:

Please mark the type of the runtime used:

• .NET Framework
• Mono
• .NET Core

• Version: 4.8

Please mark the NuGet packages used:

• Sentry
• Sentry.AspNet (manually added by me, as it is missing in the template here in GitHub)
• Sentry.Serilog
• Sentry.NLog
• Sentry.Log4Net
• Sentry.Extensions.Logging
• Sentry.AspNetCore

• Version: 3.6.0

The following LogError() call is broken, and causes the Sentry SDK to crash when triggered:

sentry-dotnet/src/Sentry/Internal/BackgroundWorker.cs

Lines 147 to 152 in a9304a0

	_options.DiagnosticLogger?.LogError(
	"Error while processing event {1}: {0}. #{2} in queue.",
	exception,
	envelope.TryGetEventId(),
	_queue.Count
	);

The problem is that the call resolves to the wrong overload of LogError() because of argument confusion in the overloads:

sentry-dotnet/src/Sentry/Extensibility/DiagnosticLoggerExtensions.cs

Lines 75 to 81 in a9304a0

	public static void LogError<TArg, TArg2>(
	this IDiagnosticLogger logger,
	string message,
	Exception exception,
	TArg arg,
	TArg2 arg2)
	=> logger.LogIfEnabled(SentryLevel.Error, message, exception, arg, arg2);

This overload only expects 2 formatting arguments, resulting in a System.FormatException further down the line because the message contains 3 placeholders.

I noticed this related issue that points out the problem with the current design of the overloads: #699