Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostic logger change order of args #699

Closed
bruno-garcia opened this issue Dec 28, 2020 · 1 comment
Closed

Diagnostic logger change order of args #699

bruno-garcia opened this issue Dec 28, 2020 · 1 comment
Assignees
@bitsandfoxes
Labels
Feature New feature or request
Milestone
4.0.0

Comments

@bruno-garcia
Copy link
Member

The LogError should take Exception as the first arg. So it doesn't get mixed up with the <TArg overloads.
There shouldn't be a nullable Exception parameter, either takes an exception or it doesnt.
@bruno-garcia bruno-garcia added the Feature New feature or request label Dec 28, 2020
@Zero3 Zero3 mentioned this issue Jun 28, 2021
Closed
17 tasks
@Tyrrrz Tyrrrz mentioned this issue Jun 29, 2021
Merged
@SimonCropp SimonCropp added this to the 4.0.0 milestone Dec 16, 2021
@bitsandfoxes bitsandfoxes self-assigned this Oct 11, 2023
@bitsandfoxes bitsandfoxes mentioned this issue Oct 11, 2023
Merged
@bitsandfoxes
Copy link
Contributor

Closed by #2715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bitsandfoxes bitsandfoxes

Labels
Feature New feature or request
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
4.0.0
Development

No branches or pull requests
4 participants
@SimonCropp @bruno-garcia @philipphofmann @bitsandfoxes