Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop ConfigureFromConfigurationOptions in AOT apps #2822

Closed
jamescrosswell opened this issue Nov 13, 2023 · 2 comments
Closed

Drop ConfigureFromConfigurationOptions in AOT apps #2822

jamescrosswell opened this issue Nov 13, 2023 · 2 comments
Assignees
@jamescrosswell @bitsandfoxes

Comments

@jamescrosswell
Copy link
Collaborator

jamescrosswell commented Nov 13, 2023 •
edited
Loading

Some of our integrations use ConfigureFromConfigurationOptions, which isn't compatible with AOT and we need to use the new configuration binding source generator:

See #2823 (comment) for detailed investigation.
@jamescrosswell jamescrosswell added this to the 4.0.0 milestone Nov 13, 2023
@jamescrosswell jamescrosswell self-assigned this Nov 13, 2023
@jamescrosswell jamescrosswell mentioned this issue Nov 13, 2023
Closed
@jamescrosswell jamescrosswell linked a pull request Nov 13, 2023 that will close this issue
Remove ConfigureFromConfigurationOptions<T> from Sentry.Extensions.Logging #2823
Merged
This was referenced Nov 15, 2023
Closed
Closed
Closed
Closed
@jamescrosswell jamescrosswell removed a link to a pull request Nov 15, 2023
Remove ConfigureFromConfigurationOptions<T> from Sentry.Extensions.Logging #2823
Merged
@jamescrosswell jamescrosswell removed this from the 4.0.0 milestone Nov 15, 2023
@jamescrosswell jamescrosswell mentioned this issue Nov 15, 2023
Closed
@bruno-garcia
Copy link
Member

We could break this up to tackle them in order (Sentry.AspNetCore is highest priority and say, Azure or MAUI lowest?)

@bruno-garcia
Copy link
Member

Noticed u did that, thanks!

@bitsandfoxes bitsandfoxes self-assigned this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamescrosswell jamescrosswell

@bitsandfoxes bitsandfoxes

Labels
None yet
Projects
GDX
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jamescrosswell @bruno-garcia @bitsandfoxes