Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong naming error with version 0.0.1-preview2 #46

Closed
xt0rted opened this issue Jul 17, 2018 · 5 comments
Closed

Strong naming error with version 0.0.1-preview2 #46

xt0rted opened this issue Jul 17, 2018 · 5 comments
Labels
Bug Something isn't working

Comments

@xt0rted
Copy link
Contributor

xt0rted commented Jul 17, 2018

I have an MVC5 site and some Azure WebJobs (plain .net 4.7.1 console apps) that are all using Microsoft.Extensions.Logging so I wanted to give the ILogger implementation a try. The WebJobs are running fine and exceptions are being logged as expected, but with the website I'm getting the following error when the site starts up:

Could not load file or assembly 'Sentry.PlatformAbstractions' or one of its dependencies. Strong name signature could not be verified. The assembly may have been tampered with, or it was delay signed but not fully signed with the correct private key. (Exception from HRESULT: 0x80131045)

I'm not sure if it matters but the WebJobs are using the new SDK style project files while the website is the old style.

  • Sentry: 0.0.1-preview2
  • Sentry.Extensions.Logging: 0.0.1-preview2
  • Sentry.PlatformAbstractions: 1.0.0-dev-00070
  • System.Collections.Immutable: 1.5.0
@bruno-garcia
Copy link
Member

bruno-garcia commented Jul 17, 2018

Strong naming is done on master but not published.
Only PlatformAbstraction was published since it's a dependency to these packages.

I'll publish the preview3 today and all assemblies will be strong named.
I'll make sure to update this ticket to let you know!

@bruno-garcia
Copy link
Member

Hi @xt0rted,
So I was actually only publicSigning the assemblies. The error you received from PlatformAbstractions would also affect the packages coming from this repo.

It's solved now. I've verified the signature and it's working propertly.

Thanks a lot for letting me know of this issue!

@bruno-garcia
Copy link
Member

Preview3 release: https://github.com/getsentry/sentry-dotnet/releases/tag/0.0.1-preview3

Thanks again for reporting the error!

@xt0rted
Copy link
Contributor Author

xt0rted commented Jul 17, 2018

Just tested it out and it's working.

I'm really liking where this new library is going, it's super easy to use if you're already using ILogger in your project. I'm able to remove my custom exception logger now and it works great with Azure WebJobs (v2 added support for ILogger at some point so this just drops in and gives unhandled exception logging without any custom code).

@bruno-garcia
Copy link
Member

You just made my day! :)
Once again thanks for reporting the bug. If you have any issues or ideas on how things can be better, please let us know ;)

@bruno-garcia bruno-garcia added the Bug Something isn't working label Sep 7, 2018
lucas-zimerman added a commit that referenced this issue Jun 27, 2021
* Add available RAM parameter (Android). (#46) @lucas-zimerman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants