-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify ifdef #1010
simplify ifdef #1010
Conversation
SetNetFxReleaseAndVersion(runtime); | ||
#elif NETSTANDARD || NETCOREAPP // Possibly .NET Core | ||
#else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we had a bug here since NETCOREAPP
was not defined in the csproj
@@ -75,15 +75,15 @@ internal static void SetNetFxReleaseAndVersion(Runtime runtime) | |||
} | |||
#endif | |||
|
|||
#if NETSTANDARD || NETCOREAPP // Possibly .NET Core | |||
#if !NET461 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here
Codecov Report
@@ Coverage Diff @@
## main #1010 +/- ##
==========================================
+ Coverage 81.24% 81.49% +0.25%
==========================================
Files 184 184
Lines 5907 5907
Branches 1456 1456
==========================================
+ Hits 4799 4814 +15
+ Misses 691 676 -15
Partials 417 417
Continue to review full report at Codecov.
|
@@ -38,7 +38,7 @@ public void Apply(Scope scope, object state) | |||
|
|||
break; | |||
} | |||
#if HAS_VALUE_TUPLE | |||
#if !NET461 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: we can bring ValueTuple
to .NET461 with: https://www.nuget.org/packages/System.ValueTuple/
This will remove the need for this if/defs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had that originally and it cause a WORLD of pain (binding redirects), so I removed it
No description provided.