simplify ifdef #1010
Merged
simplify ifdef #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
commented
May 24, 2021
| SetNetFxReleaseAndVersion(runtime); | ||
| #elif NETSTANDARD || NETCOREAPP // Possibly .NET Core | ||
| #else |
There was a problem hiding this comment.
I think we had a bug here since NETCOREAPP was not defined in the csproj
| @@ -75,15 +75,15 @@ internal static void SetNetFxReleaseAndVersion(Runtime runtime) | |||
| } | |||
| #endif | |||
|
|
|||
| #if NETSTANDARD || NETCOREAPP // Possibly .NET Core | |||
| #if !NET461 | |||
bruno-garcia
requested review from
Tyrrrz and
lucas-zimerman
and removed request for
Tyrrrz
Codecov Report
@@ Coverage Diff @@
## main #1010 +/- ##
==========================================
+ Coverage 81.24% 81.49% +0.25%
==========================================
Files 184 184
Lines 5907 5907
Branches 1456 1456
==========================================
+ Hits 4799 4814 +15
+ Misses 691 676 -15
Partials 417 417
Continue to review full report at Codecov.
|
Tyrrrz
approved these changes
May 24, 2021
| @@ -38,7 +38,7 @@ public void Apply(Scope scope, object state) | |||
|
|
|||
| break; | |||
| } | |||
| #if HAS_VALUE_TUPLE | |||
| #if !NET461 | |||
There was a problem hiding this comment.
Note: we can bring ValueTuple to .NET461 with: https://www.nuget.org/packages/System.ValueTuple/
This will remove the need for this if/defs
There was a problem hiding this comment.
I had that originally and it cause a WORLD of pain (binding redirects), so I removed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.