Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish span with exception in SentryHttpMessageHandler #1037

Merged
merged 5 commits into from Jun 3, 2021

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Jun 2, 2021

No description provided.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test that verifies this behavior and avoid regression?

@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Jun 3, 2021

Could you please add a test that verifies this behavior and avoid regression?

Good point. Done.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021

Codecov Report

Merging #1037 (ed9752f) into main (29d301a) will decrease coverage by 1.60%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1037      +/-   ##
==========================================
- Coverage   81.44%   79.83%   -1.61%     
==========================================
  Files         190      190              
  Lines        5967     5967              
  Branches     1469     1469              
==========================================
- Hits         4860     4764      -96     
- Misses        685      788     +103     
+ Partials      422      415       -7     
Impacted Files Coverage Δ
src/Sentry/SentryHttpMessageHandler.cs 79.31% <50.00%> (+6.89%) ⬆️
src/Sentry/PlatformAbstractions/FrameworkInfo.cs 0.00% <0.00%> (-100.00%) ⬇️
...ntry/PlatformAbstractions/RegistryKeyExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
...Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs 0.00% <0.00%> (-71.24%) ⬇️
...rmAbstractions/NetFxInstallationsEventProcessor.cs 4.54% <0.00%> (-68.19%) ⬇️
...ntry/Integrations/NetFxInstallationsIntegration.cs 33.33% <0.00%> (-66.67%) ⬇️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 25.00% <0.00%> (-37.50%) ⬇️
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 53.44% <0.00%> (-5.18%) ⬇️
...ry/Internal/Http/DefaultSentryHttpClientFactory.cs 58.33% <0.00%> (-4.17%) ⬇️
src/Sentry/Internal/AppDomainAdapter.cs 66.66% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d301a...ed9752f. Read the comment docs.

@Tyrrrz Tyrrrz requested a review from bruno-garcia June 3, 2021 15:43
@bruno-garcia bruno-garcia enabled auto-merge (squash) June 3, 2021 16:25
@bruno-garcia bruno-garcia merged commit b492d45 into main Jun 3, 2021
@bruno-garcia bruno-garcia deleted the fix-httphandler branch June 3, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants