Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SentryId for ISession.Id #1052

Merged
merged 5 commits into from
Jun 14, 2021
Merged

Use SentryId for ISession.Id #1052

merged 5 commits into from
Jun 14, 2021

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Jun 11, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2021

Codecov Report

Merging #1052 (b0a2f47) into main (5a573c9) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1052      +/-   ##
==========================================
- Coverage   81.42%   81.39%   -0.04%     
==========================================
  Files         193      193              
  Lines        6325     6325              
  Branches     1526     1526              
==========================================
- Hits         5150     5148       -2     
  Misses        739      739              
- Partials      436      438       +2     
Impacted Files Coverage Δ
src/Sentry/Internal/Http/HttpTransport.cs 89.85% <100.00%> (ø)
src/Sentry/Session.cs 100.00% <100.00%> (ø)
src/Sentry/SessionUpdate.cs 93.26% <100.00%> (ø)
src/Sentry/GlobalSessionManager.cs 64.03% <0.00%> (-0.88%) ⬇️
src/Sentry/Internal/BackgroundWorker.cs 84.24% <0.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a573c9...b0a2f47. Read the comment docs.

@bruno-garcia bruno-garcia merged commit 5209690 into main Jun 14, 2021
@bruno-garcia bruno-garcia deleted the session-sid-uuid branch June 14, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants