Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: EF 6 Query as Span. #1107

Merged
merged 33 commits into from Nov 9, 2021
Merged

feat: EF 6 Query as Span. #1107

merged 33 commits into from Nov 9, 2021

Conversation

@lucas-zimerman lucas-zimerman added the Feature New feature or request label Jul 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #1107 (b47c7ee) into main (b624635) will increase coverage by 0.01%.
The diff coverage is 82.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1107      +/-   ##
==========================================
+ Coverage   82.60%   82.61%   +0.01%     
==========================================
  Files         212      215       +3     
  Lines        7116     7150      +34     
  Branches     1401     1407       +6     
==========================================
+ Hits         5878     5907      +29     
- Misses        804      808       +4     
- Partials      434      435       +1     
Impacted Files Coverage Δ
....EntityFramework/SentryQueryPerformanceListener.cs 76.19% <76.19%> (ø)
.../Sentry.EntityFramework/SentryOptionsExtensions.cs 58.33% <80.00%> (+8.33%) ⬆️
...entry.EntityFramework/DbInterceptionIntegration.cs 100.00% <100.00%> (ø)
...tensions/DbCommandInterceptionContextExtensions.cs 100.00% <100.00%> (ø)
...Sentry.EntityFramework/SentryCommandInterceptor.cs 92.30% <100.00%> (+1.39%) ⬆️
src/Sentry/Internal/MonoSentryStackTraceFactory.cs 96.29% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b624635...b47c7ee. Read the comment docs.

@lucas-zimerman lucas-zimerman changed the title feat: EF/EF Core Query as Span. feat: EF Query as Span. Jul 8, 2021
@bruno-garcia bruno-garcia changed the title feat: EF Query as Span. feat: EF 6 Query as Span. Aug 4, 2021
@lucas-zimerman
Copy link
Collaborator Author

@bruno-garcia This integration will work on .NET Standard 2.1.
On, NET461 there isn't much to be done with the current version of EntityFramework. BUT, we could update it on NET461 from 6.0.0 to 6.2.0 and it should work.

@lucas-zimerman lucas-zimerman marked this pull request as ready for review September 8, 2021 17:21
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b47c7ee

@bruno-garcia
Copy link
Member

BUT, we could update it on NET461 from 6.0.0 to 6.2.0 and it should work.

We need to make this work with 4.6.1 so if we need to bump the min EF version then lets do that

6.2.0 is from 2017 so definitely not a problem: https://www.nuget.org/packages/EntityFramework/6.2.0

@lucas-zimerman
Copy link
Collaborator Author

BUT, we could update it on NET461 from 6.0.0 to 6.2.0 and it should work.

We need to make this work with 4.6.1 so if we need to bump the min EF version then lets do that

6.2.0 is from 2017 so definitely not a problem: https://www.nuget.org/packages/EntityFramework/6.2.0

That's great cus that's what I did :D (Increased EF version to 6.2.0 on NET461)

@lucas-zimerman lucas-zimerman added this to In Progress in v3.x Sep 13, 2021
samples/Sentry.Samples.EntityFramework/Program.cs Outdated Show resolved Hide resolved
src/Sentry.EntityFramework/SentryOptionsExtensions.cs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@SimonCropp SimonCropp merged commit 15064c5 into main Nov 9, 2021
@SimonCropp SimonCropp deleted the feat/ef-query branch November 9, 2021 00:01
v3.x automation moved this from In Progress to Done Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
No open projects
v3.x
Done
Development

Successfully merging this pull request may close these issues.

EF 6 Spans for queries
6 participants