Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TryRecoverPersistedSession logs debug if file doesnt exist #1123

Merged
merged 4 commits into from Jul 15, 2021

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Jul 14, 2021

Log a debug entry instead of an error because it's an expected error (TryRecoverPersistedSession() is called every time a session is started for the first time, but a left over file will actually exist very rarely).

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #1123 (ddf44ab) into main (806c489) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1123   +/-   ##
=======================================
  Coverage   80.64%   80.64%           
=======================================
  Files         197      197           
  Lines        6583     6589    +6     
  Branches     1452     1453    +1     
=======================================
+ Hits         5309     5314    +5     
  Misses        802      802           
- Partials      472      473    +1     
Impacted Files Coverage Δ
src/Sentry/GlobalSessionManager.cs 70.86% <85.71%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 806c489...ddf44ab. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@bruno-garcia bruno-garcia changed the title Don't log an error when TryRecoverPersistedSession() is called but there is no file TryRecoverPersistedSession logs debug if file doesnt exist Jul 15, 2021
@bruno-garcia bruno-garcia merged commit 10b4f6b into main Jul 15, 2021
@bruno-garcia bruno-garcia deleted the swallow-ex-in-sess branch July 15, 2021 01:09
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

- TryRecoverPersistedSession logs debug if file doesnt exist([#1123](https://github.com/getsentry/sentry-dotnet/pull/1123))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against ddf44ab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants