Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log warn in global mode #1132

Merged
merged 7 commits into from
Jul 17, 2021
Merged

fix: log warn in global mode #1132

merged 7 commits into from
Jul 17, 2021

Conversation

bruno-garcia
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2021

Codecov Report

Merging #1132 (4b58a56) into main (68dd94d) will increase coverage by 0.12%.
The diff coverage is 95.23%.

❗ Current head 4b58a56 differs from pull request most recent head e33087f. Consider uploading reports for the commit e33087f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1132      +/-   ##
==========================================
+ Coverage   80.65%   80.77%   +0.12%     
==========================================
  Files         200      200              
  Lines        6615     6615              
  Branches     1460     1464       +4     
==========================================
+ Hits         5335     5343       +8     
+ Misses        805      802       -3     
+ Partials      475      470       -5     
Impacted Files Coverage Δ
src/Sentry/Internal/Hub.cs 63.72% <94.73%> (+1.34%) ⬆️
src/Sentry/Internal/Enricher.cs 96.87% <100.00%> (-0.19%) ⬇️
src/Sentry/Internal/SentryScopeManager.cs 94.66% <100.00%> (ø)
src/Sentry/Internal/BackgroundWorker.cs 84.93% <0.00%> (+0.68%) ⬆️
...rc/Sentry/Extensibility/SentryStackTraceFactory.cs 89.24% <0.00%> (+1.07%) ⬆️
src/Sentry/Internal/MainSentryEventProcessor.cs 89.85% <0.00%> (+1.44%) ⬆️
src/Sentry/SentryClient.cs 79.68% <0.00%> (+1.56%) ⬆️
src/Sentry/Internal/MainExceptionProcessor.cs 95.08% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68dd94d...e33087f. Read the comment docs.

@bruno-garcia bruno-garcia marked this pull request as ready for review July 17, 2021 18:12
@bruno-garcia bruno-garcia merged commit a787e1f into main Jul 17, 2021
@bruno-garcia bruno-garcia deleted the fix/warning-in-global-mode branch July 17, 2021 18:27
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

- log warn in global mode([#1132](https://github.com/getsentry/sentry-dotnet/pull/1132))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against e33087f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants