Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: tunnel reduced supported tfms #1140

Merged
merged 2 commits into from
Jul 25, 2021
Merged

ref: tunnel reduced supported tfms #1140

merged 2 commits into from
Jul 25, 2021

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Jul 25, 2021

Refactors #1133

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2021

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

- tunnel reduced supported tfms([#1140](https://github.com/getsentry/sentry-dotnet/pull/1140))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 1b5ad60

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2021

Codecov Report

Merging #1140 (1b5ad60) into main (a0b454b) will decrease coverage by 0.19%.
The diff coverage is 58.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1140      +/-   ##
==========================================
- Coverage   80.79%   80.59%   -0.20%     
==========================================
  Files         200      203       +3     
  Lines        6617     6674      +57     
  Branches     1465     1476      +11     
==========================================
+ Hits         5346     5379      +33     
- Misses        800      816      +16     
- Partials      471      479       +8     
Impacted Files Coverage Δ
.../Sentry.Extensions.Logging/SentryLoggerProvider.cs 97.36% <ø> (ø)
src/Sentry.Tunnel/SentryTunnelMiddleware.cs 47.61% <47.61%> (ø)
src/Sentry/Internal/SentryJsonConverter.cs 75.00% <75.00%> (ø)
...nel/SentryTunnelingApplicationBuilderExtensions.cs 100.00% <100.00%> (ø)
src/Sentry/Internal/Extensions/JsonExtensions.cs 76.47% <100.00%> (+0.63%) ⬆️
src/Sentry/Internal/BackgroundWorker.cs 84.24% <0.00%> (-0.69%) ⬇️
src/Sentry/GlobalSessionManager.cs 71.20% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd03fe1...1b5ad60. Read the comment docs.

@bruno-garcia bruno-garcia changed the title ref: tunnel ref: tunnel reduced supported tfms Jul 25, 2021
@bruno-garcia bruno-garcia merged commit b0151a2 into main Jul 25, 2021
@bruno-garcia bruno-garcia deleted the ref/tunnel branch July 25, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants