Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a notification layer to scope mutation #1153

Merged
merged 16 commits into from
Aug 23, 2021
Merged

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Aug 5, 2021

Implements a one-way scope synchronization with the main SDK's scope with an external scope if EnableScopeSync is set to true.
Close #1114.

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2021

Codecov Report

Merging #1153 (fe5b40e) into main (1ea7450) will increase coverage by 0.06%.
The diff coverage is 91.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
+ Coverage   80.50%   80.57%   +0.06%     
==========================================
  Files         204      204              
  Lines        6689     6727      +38     
  Branches     1482     1495      +13     
==========================================
+ Hits         5385     5420      +35     
  Misses        821      821              
- Partials      483      486       +3     
Impacted Files Coverage Δ
src/Sentry/Scope.cs 92.20% <85.71%> (-1.69%) ⬇️
src/Sentry/SentryOptions.cs 89.57% <100.00%> (+0.12%) ⬆️
src/Sentry/User.cs 85.45% <100.00%> (+4.50%) ⬆️
src/Sentry/GlobalSessionManager.cs 69.58% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea7450...fe5b40e. Read the comment docs.

@lucas-zimerman lucas-zimerman marked this pull request as ready for review August 5, 2021 20:01
@lucas-zimerman lucas-zimerman marked this pull request as draft August 6, 2021 12:51
@lucas-zimerman lucas-zimerman marked this pull request as ready for review August 6, 2021 14:04
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/Sentry/IScopeObserver.cs Outdated Show resolved Hide resolved
src/Sentry/IScopeObserver.cs Outdated Show resolved Hide resolved
src/Sentry/Scope.cs Outdated Show resolved Hide resolved
src/Sentry/User.cs Outdated Show resolved Hide resolved
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐿️
I mean
:shipit:

src/Sentry/Scope.cs Outdated Show resolved Hide resolved
src/Sentry/Scope.cs Outdated Show resolved Hide resolved
test/Sentry.Tests/ScopeTests.cs Outdated Show resolved Hide resolved
@lucas-zimerman lucas-zimerman merged commit ffcfc24 into main Aug 23, 2021
@lucas-zimerman lucas-zimerman deleted the feat/scope-mutation branch August 23, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a notification layer to scope mutation
3 participants