Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix end session from Hub Adapter. #1158

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Aug 16, 2021

the argument received from EndSession was ignored.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2021

Codecov Report

Merging #1158 (4b07e2b) into main (45f95bb) will decrease coverage by 1.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1158      +/-   ##
==========================================
- Coverage   80.47%   79.04%   -1.44%     
==========================================
  Files         204      204              
  Lines        6689     6689              
  Branches     1482     1482              
==========================================
- Hits         5383     5287      -96     
- Misses        823      929     +106     
+ Partials      483      473      -10     
Impacted Files Coverage Δ
src/Sentry/Extensibility/HubAdapter.cs 66.66% <100.00%> (+3.03%) ⬆️
src/Sentry/PlatformAbstractions/FrameworkInfo.cs 0.00% <0.00%> (-100.00%) ⬇️
...ntry/PlatformAbstractions/RegistryKeyExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
...Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs 0.00% <0.00%> (-70.43%) ⬇️
...rmAbstractions/NetFxInstallationsEventProcessor.cs 4.54% <0.00%> (-68.19%) ⬇️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 25.00% <0.00%> (-37.50%) ⬇️
...ntry/Integrations/NetFxInstallationsIntegration.cs 28.57% <0.00%> (-28.58%) ⬇️
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 54.23% <0.00%> (-5.09%) ⬇️
src/Sentry/Internal/AppDomainAdapter.cs 66.66% <0.00%> (ø)
src/Sentry/Internal/BackgroundWorker.cs 84.93% <0.00%> (+0.68%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45f95bb...4b07e2b. Read the comment docs.

@bruno-garcia bruno-garcia enabled auto-merge (squash) August 19, 2021 15:53
@bruno-garcia bruno-garcia merged commit 1ea7450 into main Aug 19, 2021
@bruno-garcia bruno-garcia deleted the fix/hub-adapter-endsesion branch August 19, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants