Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: braces from tag keys on DefaultSentryScopeStateProcessor. #1183

Merged
merged 8 commits into from
Sep 9, 2021

Conversation

lucas-zimerman
Copy link
Collaborator

This PR removes any brackets from keys applied on DefaultSentryScopeStateProcessor if state is IEnumerable<KeyValuePair<string, object>>

Close #1177.

@lucas-zimerman lucas-zimerman added the Bug Something isn't working label Sep 2, 2021
@lucas-zimerman lucas-zimerman changed the title Fix: bracket tag keys. Fix: braces from tag keys on DefaultSentryScopeStateProcessor. Sep 2, 2021
@lucas-zimerman lucas-zimerman marked this pull request as ready for review September 2, 2021 17:13
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #1183 (250152f) into main (b55b55c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1183      +/-   ##
==========================================
+ Coverage   80.47%   80.48%   +0.01%     
==========================================
  Files         212      212              
  Lines        6887     6888       +1     
  Branches     1571     1571              
==========================================
+ Hits         5542     5544       +2     
+ Misses        826      823       -3     
- Partials      519      521       +2     
Impacted Files Coverage Δ
src/Sentry/DefaultSentryScopeStateProcessor.cs 66.66% <100.00%> (+1.96%) ⬆️
src/Sentry/Internal/BackgroundWorker.cs 83.33% <0.00%> (-0.73%) ⬇️
src/Sentry/Internal/Hub.cs 65.67% <0.00%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b55b55c...250152f. Read the comment docs.

@lucas-zimerman lucas-zimerman merged commit a12bb9f into main Sep 9, 2021
@lucas-zimerman lucas-zimerman deleted the fix/bracket-tag-keys branch September 9, 2021 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid data (invalid character '{') in path
4 participants