Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unhandled error crashed session #1193

Merged
merged 3 commits into from Sep 10, 2021

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Sep 10, 2021

Exceptions from UnhandledExceptionIntegration were not marking sessions as crashed

@bruno-garcia bruno-garcia force-pushed the fix/unhandled-exception-crashed-session branch from 4a9a378 to 570e2a9 Compare September 10, 2021 22:04
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2021

Codecov Report

Merging #1193 (570e2a9) into main (8a30540) will decrease coverage by 1.39%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1193      +/-   ##
==========================================
- Coverage   80.51%   79.11%   -1.40%     
==========================================
  Files         212      212              
  Lines        6888     6891       +3     
  Branches     1571     1573       +2     
==========================================
- Hits         5546     5452      -94     
- Misses        822      930     +108     
+ Partials      520      509      -11     
Impacted Files Coverage Δ
src/Sentry/SentryEvent.cs 95.79% <80.00%> (-0.70%) ⬇️
src/Sentry/Internal/Hub.cs 66.33% <100.00%> (+0.66%) ⬆️
src/Sentry/PlatformAbstractions/FrameworkInfo.cs 0.00% <0.00%> (-100.00%) ⬇️
...ntry/PlatformAbstractions/RegistryKeyExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
...Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs 0.00% <0.00%> (-70.43%) ⬇️
...rmAbstractions/NetFxInstallationsEventProcessor.cs 4.54% <0.00%> (-68.19%) ⬇️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 25.00% <0.00%> (-37.50%) ⬇️
...ntry/Integrations/NetFxInstallationsIntegration.cs 28.57% <0.00%> (-28.58%) ⬇️
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 53.44% <0.00%> (-5.18%) ⬇️
src/Sentry/Internal/AppDomainAdapter.cs 66.66% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a30540...570e2a9. Read the comment docs.

@bruno-garcia bruno-garcia enabled auto-merge (squash) September 10, 2021 22:07
@bruno-garcia bruno-garcia merged commit 997a310 into main Sep 10, 2021
@bruno-garcia bruno-garcia deleted the fix/unhandled-exception-crashed-session branch September 10, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants