Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: block init flush tests (use new net6 API) #1228

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Sep 30, 2021

Seems the InitCacheFlushTimeout feature doesn't have any tests.
We can improve the code on net6.0 but it requires some test first.

See also #1164

@bruno-garcia bruno-garcia changed the base branch from main to explore/net6 September 30, 2021 01:59
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2021

Codecov Report

Merging #1228 (a5a952a) into explore/net6 (92b7100) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head a5a952a differs from pull request most recent head 33225f9. Consider uploading reports for the commit 33225f9 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           explore/net6    #1228      +/-   ##
================================================
+ Coverage         80.59%   80.67%   +0.08%     
================================================
  Files               212      212              
  Lines              6904     6918      +14     
  Branches           1587     1587              
================================================
+ Hits               5564     5581      +17     
+ Misses              809      806       -3     
  Partials            531      531              
Impacted Files Coverage Δ
...grations/AppDomainUnhandledExceptionIntegration.cs 86.66% <ø> (ø)
...grations/TaskUnobservedTaskExceptionIntegration.cs 91.66% <ø> (ø)
src/Sentry/Internal/AppDomainAdapter.cs 66.66% <ø> (ø)
src/Sentry/Internal/Polyfills.cs 75.00% <ø> (ø)
src/Sentry/Internal/SynchronizedRandom.cs 100.00% <100.00%> (ø)
...ntry/PlatformAbstractions/FrameworkInstallation.cs 62.50% <0.00%> (ø)
src/Sentry/Internal/BackgroundWorker.cs 84.05% <0.00%> (+0.72%) ⬆️
src/Sentry/Infrastructure/TraceDiagnosticLogger.cs 27.27% <0.00%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f8926e...33225f9. Read the comment docs.

@bruno-garcia bruno-garcia marked this pull request as draft September 30, 2021 02:09
@bruno-garcia bruno-garcia changed the title test/block init flush test: block init flush tests (use new net6 API) Sep 30, 2021
@bruno-garcia bruno-garcia marked this pull request as ready for review September 30, 2021 02:16
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

- block init flush tests (use new net6 API)([#1228](https://github.com/getsentry/sentry-dotnet/pull/1228))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 33225f9

@bruno-garcia bruno-garcia merged commit 552f58c into explore/net6 Oct 26, 2021
@bruno-garcia bruno-garcia deleted the test/block-init-flush branch October 26, 2021 15:20
@bruno-garcia bruno-garcia mentioned this pull request Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants