Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust database span naming convention. #1502

Merged
merged 5 commits into from
Mar 2, 2022
Merged

Conversation

lucas-zimerman
Copy link
Collaborator

  • Operation names containing _ got replaced by . to align with the new SDK format.
  • db.query_compiler got renamed to db.query.compile

Sub task from #1497

@github-actions github-actions bot added this to In progress in Default Feb 28, 2022
@lucas-zimerman lucas-zimerman changed the title Adjust database spam naming convention. Adjust database span naming convention. Feb 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2022

Codecov Report

Merging #1502 (0b9288d) into main (6ca55c0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1502   +/-   ##
=======================================
  Coverage   84.23%   84.23%           
=======================================
  Files         219      219           
  Lines        7388     7388           
  Branches     1416     1416           
=======================================
  Hits         6223     6223           
  Misses        733      733           
  Partials      432      432           
Impacted Files Coverage Δ
....EntityFramework/SentryQueryPerformanceListener.cs 86.36% <ø> (ø)
...Internals/DiagnosticSource/SentryEFCoreListener.cs 89.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca55c0...0b9288d. Read the comment docs.

@lucas-zimerman lucas-zimerman marked this pull request as ready for review February 28, 2022 15:27
fix pr number.
@lucas-zimerman lucas-zimerman merged commit 78d1552 into main Mar 2, 2022
Default automation moved this from In progress to Done Mar 2, 2022
@lucas-zimerman lucas-zimerman deleted the ref/db-spans-format branch March 2, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants