Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for PII breadcrumbs from MAUI events #1709

Merged
merged 5 commits into from Jun 13, 2022

Conversation

mattjohnsonpint
Copy link
Contributor

Disables automatically adding breadcrumbs from MAUI events that might contain PII, and adds options to enable them if desired.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we flip them all to true if SendDefaultPii is true?

@mattjohnsonpint
Copy link
Contributor Author

Nah, I think they shouldn't be considered "default" PII at all. (Most people won't want them on in production, but may turn them on while troubleshooting.)

@mattjohnsonpint mattjohnsonpint merged commit d29ae07 into main Jun 13, 2022
@mattjohnsonpint mattjohnsonpint deleted the maui-pii-options branch June 13, 2022 23:52
@mattjohnsonpint mattjohnsonpint mentioned this pull request Jun 14, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants