Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch Android/MAUI permission exceptions #1750

Merged
merged 3 commits into from
Jun 25, 2022
Merged

Conversation

mattjohnsonpint
Copy link
Contributor

Battery and Network device info is not available unless the application has specific permissions. Swallow those permission errors.

Neither is reading the process start time. We may be able to find a better way to collect this later, but for now just use "Fast" mode instead of "Best".

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's worth compiling out the Best on Android. Or compile an Obsolete so it warns if they use it?

@mattjohnsonpint
Copy link
Contributor Author

I wonder if it's worth compiling out the Best on Android. Or compile an Obsolete so it warns if they use it?

Makes sense. Added a commit for that.

@mattjohnsonpint mattjohnsonpint merged commit 3bab125 into main Jun 25, 2022
@mattjohnsonpint mattjohnsonpint deleted the fix-maui-exceptions branch June 25, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants