feat: Capture Debug Images and StackFrame fields for Portable PDB symbolication #1785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the new event properties defined in RFC 0013, namely InstructionAddress / FunctionId + Relative Indexing, and a list of
pe_dotnet
DebugImages.The new information allows symbolicating .NET stack traces on symbolicator, using uploaded Portable PDB debug files.
Example events that were captured with this PR and symbolicated serverside:
The second event might be an example where it could be possible to load debug symbols from the Microsoft Symbol Server which is not possible yet, but we might add this later.
I open this PR with the hope of either delegating it to the .NET team, or at the very least get some dedicated mentoring to finish it up.
The problem I see right now are: